Skip to content

[wasm][aot] Disable tests that are failing because they depend on stacktrace API - #54286

Merged
radical merged 3 commits into
dotnet:mainfrom
radical:wasm-aot-disable-tests
Jun 16, 2021
Merged

[wasm][aot] Disable tests that are failing because they depend on stacktrace API#54286
radical merged 3 commits into
dotnet:mainfrom
radical:wasm-aot-disable-tests

Conversation

@radical

@radical radical commented Jun 16, 2021

Copy link
Copy Markdown
Member

@radical radical added arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test labels Jun 16, 2021
@radical
radical requested a review from lewing June 16, 2021 17:18
@ghost

ghost commented Jun 16, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

ghost commented Jun 16, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: radical
Assignees: -
Labels:

arch-wasm, wasm-aot-test

Milestone: -

Comment thread src/libraries/tests.proj

<!-- Issue: https://github.com/dotnet/runtime/issues/50959 -->
<!-- Issue: https://github.com/dotnet/runtime/issues/50957 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.IO.Pipelines\tests\System.IO.Pipelines.Tests.csproj" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we remove the exclusions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this and more. But as a separate PR.
This one will unblock the tracking PR. And then a follow up PR would enable the ones that have been stable on the tracking one.

@radical

radical commented Jun 16, 2021

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@radical

radical commented Jun 16, 2021

Copy link
Copy Markdown
Member Author

/azp run runtime,runtime-staging

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@radical
radical merged commit e5c4e14 into dotnet:main Jun 16, 2021
@radical
radical deleted the wasm-aot-disable-tests branch June 16, 2021 19:30
@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants