Optionally capture a dump during generational aware analysis - #54517
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsThis change introduces an extra option to allow generational aware analysis to capture a dump in addition to the trace files. The trace file contains information about the type of object that held the young objects alive, but very often, we also need to know the exact instance. This is particularly useful when the young objects are leaked by a delegate, where we would like to know which callback is causing the problem. @dotnet/dotnet-diag
|
noahfalk
left a comment
There was a problem hiding this comment.
Looks fine to me, @mikem8361 you want to take a look as well?
|
@Maoni0, can you please approve the PR if the change is good from the GC's perspective? |
|
looks good from GC's POV. |
noahfalk
left a comment
There was a problem hiding this comment.
Still looks good to me : )
(And thanks for the little refactor on GenerateDump)
hoyosjs
left a comment
There was a problem hiding this comment.
Dump changes and EP changes look like a cleanup to me :)
This change introduces an extra option to allow generational aware analysis to capture a dump in addition to the trace files.
The trace file contains information about the type of object that held the young objects alive, but very often, we also need to know the exact instance. This is particularly useful when the young objects are leaked by a delegate, where we would like to know which callback is causing the problem.
@dotnet/dotnet-diag