Fix WaitForNextTickAsync_CanceledWaitThenWaitAgain_Succeeds test - #54775
Merged
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There's a race condition in the test between the timer firing and cancellation being requested. It repros more on Linux because there's a smaller quantum on Linux than on Windows.
stephentoub
force-pushed
the
fixperiodictest
branch
from
June 26, 2021 13:52
a1d5001 to
3d32728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a race condition in the test between the timer firing and cancellation being requested. It repros more on Linux because there's a smaller quantum on Linux than on Windows.
Fixes #54713