Avoid finalizer race in the SslStreamNetworkStreamTests cert creation - #57381
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsThe TestHelpers.GenerateCertificates implementation for extending the length of the Rather than rebuild the chain after the fact, this change just asks the PKI builder to build a longer chain.
|
Contributor
|
Failing test is unrelated and already "fixed" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TestHelpers.GenerateCertificates implementation for extending the length of the
certificate chain had a finalizable value race condition: if the
endEntitycertificate gotfinalized between the time the private key handle was obtained and the key got rebound
to the new copy, then the key object was pointing at a deleted key and the operation failed.
Rather than rebuild the chain after the fact, this change just asks the PKI builder to build a longer chain.
Fixes #53597.