-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add tests for notification profilers #57429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
592ecf8
Small fixes, add tests
davmason d3bf163
update tests
davmason 67bac3b
Updates
davmason 2b78825
Add guid for cross plat
davmason 86a1601
Update multiple.cpp
davmason 0276594
Reduce number of profilers because 32 made the test take forever
davmason f2a5e37
Lower again
davmason 917b969
add newlines
davmason abae1b0
Adjust expected ms
davmason File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.Runtime.CompilerServices; | ||
| using System.Runtime.InteropServices; | ||
| using System.Threading; | ||
|
|
||
| namespace Profiler.Tests | ||
| { | ||
| class MultiplyLoaded | ||
| { | ||
| static readonly Guid MultipleProfilerGuid = new Guid("BFA8EF13-E144-49B9-B95C-FC1C150C7651"); | ||
| static readonly string ProfilerPath = ProfilerTestRunner.GetProfilerPath(); | ||
|
|
||
| [DllImport("Profiler")] | ||
| private static extern void PassCallbackToProfiler(ProfilerCallback callback); | ||
|
|
||
| public static int RunTest(String[] args) | ||
| { | ||
| ManualResetEvent _profilerDone = new ManualResetEvent(false); | ||
| PassCallbackToProfiler(() => _profilerDone.Set()); | ||
|
|
||
| ProfilerControlHelpers.AttachProfilerToSelf(MultipleProfilerGuid, ProfilerPath); | ||
|
|
||
| try | ||
| { | ||
| Console.WriteLine("Throwing exception"); | ||
| throw new Exception("Test exception!"); | ||
| } | ||
| catch | ||
| { | ||
| // intentionally swallow the exception | ||
| Console.WriteLine("Exception caught"); | ||
| } | ||
|
|
||
| Console.WriteLine("Waiting for profilers to all detach"); | ||
| if (!_profilerDone.WaitOne(TimeSpan.FromMinutes(5))) | ||
| { | ||
| Console.WriteLine("Profiler did not set the callback, test will fail."); | ||
| } | ||
|
|
||
| return 100; | ||
| } | ||
|
|
||
| public static int Main(string[] args) | ||
| { | ||
| if (args.Length > 0 && args[0].Equals("RunTest", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| return RunTest(args); | ||
| } | ||
|
|
||
| return ProfilerTestRunner.Run(profileePath: System.Reflection.Assembly.GetExecutingAssembly().Location, | ||
| testName: "MultiplyLoaded", | ||
| profilerClsid: MultipleProfilerGuid, | ||
| loadAsNotification: true, | ||
| notificationCopies: 2); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworkIdentifier>.NETCoreApp</TargetFrameworkIdentifier> | ||
| <OutputType>exe</OutputType> | ||
| <CLRTestKind>BuildAndRun</CLRTestKind> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <CLRTestPriority>0</CLRTestPriority> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="$(MSBuildProjectName).cs" /> | ||
| <ProjectReference Include="$(TestSourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" /> | ||
| <ProjectReference Include="../common/profiler_common.csproj" /> | ||
| <ProjectReference Include="$(MSBuildThisFileDirectory)/../native/CMakeLists.txt" /> | ||
| </ItemGroup> | ||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to new line these? All others don't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are printed to the debugger and without a newline it would get printed all on one line. I added newlines to all the profiler ones so they are consistent