Skip to content

Consume PosixSignal in Hosting.Systemd's SystemdLifetime - #59880

Merged
eerhardt merged 4 commits into
dotnet:mainfrom
eerhardt:Fix56058
Nov 1, 2021
Merged

Consume PosixSignal in Hosting.Systemd's SystemdLifetime#59880
eerhardt merged 4 commits into
dotnet:mainfrom
eerhardt:Fix56058

Conversation

@eerhardt

@eerhardt eerhardt commented Oct 1, 2021

Copy link
Copy Markdown
Member

Fix #56058

@eerhardt
eerhardt requested review from maryamariyan and tmds October 1, 2021 21:43
@ghost

ghost commented Oct 1, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Oct 1, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #56058

Author: eerhardt
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Hosting
Milestone: -

tmds
tmds reviewed Oct 6, 2021
View reviewed changes
Comment thread src/libraries/Microsoft.Extensions.Hosting.Systemd/src/SystemdLifetime.netcoreapp.cs Outdated
stephentoub
stephentoub reviewed Oct 13, 2021
View reviewed changes
Comment thread src/libraries/Microsoft.Extensions.Hosting.Systemd/src/SystemdNotifier.cs
@eerhardt

eerhardt commented Oct 21, 2021

Copy link
Copy Markdown
Member Author

Thanks for all the feedback so far.

I believe this is ready for another review.

This was referenced Oct 22, 2021
Closed
Closed
Open
@eerhardt

eerhardt commented Oct 28, 2021

Copy link
Copy Markdown
Member Author

CI failures are #60731

@tmds @stephentoub @maryamariyan - any more thoughts here?

tmds
tmds approved these changes Oct 28, 2021
View reviewed changes

@tmds tmds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@eerhardt
Merge branch 'main' into Fix56058
b34a944
@eerhardt
Fix TFMs to correctly include NetCoreApp
e48b6cf 
Also fixing duplicate entries in the .sln file, since it doesn't load correctly.
@eerhardt

eerhardt commented Oct 28, 2021

Copy link
Copy Markdown
Member Author

FYI @ViktorHofer - this is the change I mentioned to you offline, if you want to take a look at the project changes. I think I got them right, but it would be great to confirm.

ViktorHofer
ViktorHofer approved these changes Oct 28, 2021
View reviewed changes

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The msbuild project file changes look right.

@eerhardt eerhardt mentioned this pull request Oct 28, 2021
Closed
49 tasks
@eerhardt
eerhardt merged commit 759057f into dotnet:main Nov 1, 2021
@eerhardt
eerhardt deleted the Fix56058 branch November 1, 2021 17:28
@ghost ghost locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub left review comments
@ViktorHofer ViktorHofer ViktorHofer approved these changes
+2 more reviewers
@tmds tmds tmds approved these changes
@maryamariyan maryamariyan maryamariyan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-Hosting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consume PosixSignal in Microsoft.Extensions.Hosting.Systemd's SystemdLifetime

5 participants

@eerhardt @tmds @stephentoub @maryamariyan @ViktorHofer