Skip to content

Fix Errors in performance-setup Scripts From PR 59483 - #60073

Merged
Tohron merged 1 commit into
mainfrom
performance-setup-fix
Oct 6, 2021
Merged

Fix Errors in performance-setup Scripts From PR 59483#60073
Tohron merged 1 commit into
mainfrom
performance-setup-fix

Conversation

@Tohron

@Tohron Tohron commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

#59483 was merged to resolve issues with performance setup scripts not returning a nonzero exit code when they encountered failures, but some errors were found after it was merged. This PR is to address those errors.

@Tohron Tohron added the tenet-performance Performance related issue label Oct 6, 2021
@Tohron
Tohron requested review from LoopedBard3 and billwert October 6, 2021 16:46
@ghost

ghost commented Oct 6, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

#59483 was merged to resolve issues with performance setup scripts not returning a nonzero exit code when they encountered failures, but some errors were found after it was merged. This PR is to address those errors.

Author: Tohron
Assignees: -
Labels:

area-Infrastructure-libraries, tenet-performance

Milestone: -

@LoopedBard3 LoopedBard3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tohron
Tohron merged commit a442df0 into main Oct 6, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants