Skip to content

Fix performance-setup Function Definitions - #60102

Merged
Tohron merged 3 commits into
mainfrom
performance-setup-fix
Oct 6, 2021
Merged

Fix performance-setup Function Definitions#60102
Tohron merged 3 commits into
mainfrom
performance-setup-fix

Conversation

@Tohron

@Tohron Tohron commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

There are still issues with the new functions defined in performance-setup.ps1. This PR is to resolve those issues

@Tohron Tohron added the tenet-performance Performance related issue label Oct 6, 2021
@Tohron
Tohron requested a review from LoopedBard3 October 6, 2021 22:53
@ghost

ghost commented Oct 6, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

There are still issues with the new functions defined in performance-setup.ps1. This PR is to resolve those issues

Author: Tohron
Assignees: -
Labels:

area-Infrastructure-libraries, tenet-performance

Milestone: -


Move-Item -Path $Path -Destination $Destination
if (!$?) {
Write-Output "Failed to move $Source to $Destination"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this $Source supposed to be $Path?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Tohron
Tohron merged commit d2a05e3 into main Oct 6, 2021
@safern
safern deleted the performance-setup-fix branch October 6, 2021 23:01
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants