Move diagnostics for invalid GeneratedDllImportAttribute usage to generator instead of analyzer - #65915
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsMake the generator emit a diagnostic for any methods marked Fixes #62700
|
…erator instead of analyzer
elinor-fung
force-pushed
the
invalidUsageDiag
branch
from
February 26, 2022 01:48
62eee40 to
5b2cbaa
Compare
AaronRobinsonMSFT
approved these changes
Feb 26, 2022
Member
Author
|
Faliures are #65890 |
Contributor
|
Perfect thanks @elinor-fung |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the generator emit a diagnostic for any methods marked
GeneratedDllImportthat it is going to ignore. We had diagnostics in a separate analyzer (in the same DLL), but that could be turned off independently from the generator - this makes it so that invalid usage issues can't be missed.Fixes #62700