Fix JsonSerializer src-gen issues with reference handler feature - #66422
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsFixes #64813.
|
eiriktsarpalis
approved these changes
Mar 10, 2022
eiriktsarpalis
left a comment
Member
There was a problem hiding this comment.
LGTM, merge away whenever CI is happy.
layomia
force-pushed
the
ReferenceHandlingSrcGen
branch
from
March 11, 2022 21:13
ef19f73 to
f88b06c
Compare
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
…net#66422) * Fix JsonSerializer src-gen issues with reference handler feature * Add Newtonsoft.Json reference to src-gen test project * Fix failing tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64813.