Add lowering for get_One, get_AllBitSet, createScalar(), createScalarUnsafe(). - #83402
Merged
Merged
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak |
Contributor
Author
|
@tannergooding @BruceForstall @anthonycanino Had to add a new instruction VPTERNLOG since cmp instruction previously used to set all bits would write result to k register. And that is not ideal. Everything else should be straightforward |
DeepakRajendrakumaran
marked this pull request as draft
March 14, 2023 17:29
DeepakRajendrakumaran
force-pushed
the
vector512API_2
branch
from
March 14, 2023 17:40
f5b8330 to
f6ca00a
Compare
DeepakRajendrakumaran
force-pushed
the
vector512API_2
branch
from
March 14, 2023 17:56
f6ca00a to
2686ec0
Compare
DeepakRajendrakumaran
force-pushed
the
vector512API_2
branch
2 times, most recently
from
March 14, 2023 22:12
42dbaaa to
6096524
Compare
DeepakRajendrakumaran
marked this pull request as ready for review
March 14, 2023 22:38
tannergooding
approved these changes
Mar 14, 2023
tannergooding
approved these changes
Mar 15, 2023
Member
|
CC. @dotnet/jit-contrib, @dotnet/avx512-contrib for secondary review/sign-off Failures are #83298 which has a revert PR up #83412 Tests covering the relevant changes did run and pass, despite the timeouts (can see that in the console log by searching for |
EgorBo
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes progress towards #80814. Also helps with #83354