Remove unused helix queue definitions - #85018
Merged
jkoritzinsky merged 1 commit intoApr 19, 2023
Merged
Conversation
We don't run tests on official builds since repo consolidation in .NET 5. We used to run tests on official builds back in dotnet/coreclr, but we discontinued that practice. This YAML was all included in support of doing so. As a result, it's been dead for years and just clutters up our pipeline definitions and creates confusion.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsWe don't run tests on official builds since repo consolidation in .NET 5. We used to run tests on official builds back in dotnet/coreclr, but we discontinued that practice. This YAML was all included in support of doing so. As a result, it's been dead for years and just clutters up our pipeline definitions and creates confusion.
|
sbomer
approved these changes
Apr 19, 2023
sbomer
left a comment
Member
There was a problem hiding this comment.
LGTM overall, just wanted to make sure I follow the reasoning behind some of the removals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't run tests on official builds since repo consolidation in .NET 5. We used to run tests on official builds back in dotnet/coreclr, but we discontinued that practice. This YAML was all included in support of doing so. As a result, it's been dead for years and just clutters up our pipeline definitions and creates confusion.
Closes #57007