Enable option to use the Windows ThreadPool - #85373

Merged

eduardo-vp merged 172 commits into

dotnet:mainfrom

eduardo-vp:feature/enable-windows-threadpool

Jun 15, 2023

Commits on Mar 8, 2023

Split RegisteredWaitHandle.Portable.cs
eduardo-vp
committed
2d5b4c6
Split ThreadPoolBoundHandle.cs
eduardo-vp
committed
5860353
Create WindowsThreadPool.cs and update ThreadPool files
eduardo-vp
committed
c0283b6

Commits on Mar 13, 2023

Move Win32ThreadPoolBoundHandle.cs implementation to ThreadPoolBoundHandle.WindowsThreadPool.cs
eduardo-vp
committed
33083ee

Commits on Mar 14, 2023

Commits on Mar 16, 2023

Fix some dependencies
eduardo-vp
committed
a3d1aea

Commits on Mar 23, 2023

Fix some build errors
eduardo-vp
committed
50d8155
Split Thread.NativeAot.cs and create Thread.CoreCLR.Windows.cs
eduardo-vp
committed
911f415
More errors fixed
eduardo-vp
committed
e0fb07c

Commits on Mar 24, 2023

Fix next set of errors
eduardo-vp
committed
b5f2859

Commits on Mar 25, 2023

Fix more build errors
eduardo-vp
committed
c6a9d1c

Commits on Apr 5, 2023

Restore Thread files
eduardo-vp
committed
b7ddda0
Adding some comments
eduardo-vp
committed
13894d0
Restore WaitHandle
eduardo-vp
committed
7367244

Commits on Apr 6, 2023

Fix dependencies
eduardo-vp
committed
aa0c74e
Add some pragmas
eduardo-vp
committed
af6cfd6

Commits on Apr 7, 2023

Before adding SafeThreadPoolIOHandle
eduardo-vp
committed
d2de264

Commits on Apr 14, 2023

Add SafeThreadPoolIOHandle and Interop.ThreadPoolIO.cs
eduardo-vp
committed
9da7ec3
Most errors fixed
eduardo-vp
committed
6c420fa

Commits on Apr 15, 2023

Fix CoreCLR errors
eduardo-vp
committed
157508d
Fix some NativeAOT errors
eduardo-vp
committed
1f54bd2

Commits on Apr 17, 2023

Fix building errors
eduardo-vp
committed
6a972ed

Commits on Apr 24, 2023

Fix RegisteredWaitHandle
eduardo-vp
committed
4727ea3

Commits on Apr 25, 2023

Remove AotCommonPath + Sort Aot dependencies
eduardo-vp
committed
cb38e38
OnFinalRelease only if WindowsThreadPool is enabled
eduardo-vp
committed
25319b4

Commits on Apr 26, 2023

Commits on Apr 27, 2023

Move switch files to libraries and rename them
eduardo-vp
committed
7fc89a6

Commits on Apr 28, 2023

Move nativeaot files under libraries
eduardo-vp
committed
5e4e6cd
NativeAotSourcesRoot
eduardo-vp
committed
4cc04db
Move Portable ThreadPool implementation to ThreadPool.CoreCLR.Core.cs. This will allow Mono to switch between Portable and Windows thread pool
eduardo-vp
committed
1d654d6
Allow Mono to switch between portable and windows thread pool
eduardo-vp
committed
5c8d29c
Delete UnmanagedThreadPoolWorkItem + place calls to PortableThreadPool in ThreadPool.cs only
eduardo-vp
committed
e4612e5
Move imports of Interop.ThreadPool.cs and Interop.ThreadPoolIO.cs to libraries
eduardo-vp
committed
64b279b
Make *Core methods private
eduardo-vp
committed
4a97daf
Restore compability supressions
eduardo-vp
committed
272455c
Remove ThreadPool.CoreCLR.cs
eduardo-vp
committed
a8278b5
Remove PreAllocatedOverlapped.Portable.cs
eduardo-vp
committed
03dfd3e
Move CompleteWaitThreadPoolWorkItem to libraries
eduardo-vp
committed
26bd6ac

Commits on May 2, 2023

Move most of ThreadPool.CoreCLR.Core to libraries
eduardo-vp
committed
42f3317

Commits on May 3, 2023

Commits on May 4, 2023

Camel case used in overlapped files
eduardo-vp
committed
0cb6edd
Revert changes in RuntimeEventSource
eduardo-vp
committed
4296e0a
Fix NativeAOT build
eduardo-vp
committed
89f10b5
Move Win32ThreadPoolPreAllocatedOverlapped.cs and Win32ThreadPoolRegisteredWaitHandle.cs to libraries
eduardo-vp
committed
3c5d3f6
Revert changes in Thread.cs and ThreadPool.Portable.Unix.cs. Rename the latter to ThreadPool.Unix.cs
eduardo-vp
committed
a6f967b
Allow NativeAOT to switch between windows and portable threadpoopl
eduardo-vp
committed
a76d74c
Remote ThreadPool.Windows.cs
eduardo-vp
committed
e98773a

Commits on May 5, 2023

Fix clr on unix
eduardo-vp
committed
edc7a2f
Fix clr on windows
eduardo-vp
committed
4672af9

Commits on May 8, 2023

RegisteredWaitHandle properties using corresponding fields
eduardo-vp
committed
90edcbe
Nit in RegisteredWaitHandle.cs
eduardo-vp
committed
328786b

Commits on May 9, 2023

Commits on May 10, 2023

Commits on May 11, 2023

Commits on May 12, 2023

Add Trimming tests
eduardo-vp
committed
a1b785e
Update System.Runtime.TrimmingTests.proj - run tests on Windows only
eduardo-vp
committed
f1808b7
Setting default value of UseWindowsThreadPool to true. Just for testing
eduardo-vp
committed
fba93f3

Commits on May 15, 2023

Enable ThreadPoolCallbackWrapper in NativeAOT
eduardo-vp
committed
352cb73

Commits on May 17, 2023

Commits on May 18, 2023

Adding xml to PreAllocatedOverlapped::UnsafeCreate
eduardo-vp
committed
9a33eeb
Remove xml from PreAllocatedOverlapped::UnsafeCreatePortableCore
eduardo-vp
committed
bb8c78d
Sort usings
eduardo-vp
committed
e074410
Update src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPoolWorkQueue.cs

eduardo-vp
and
kouvel
authored
4d1c2dd
Renaming: *Core to *WindowsThreadPool
eduardo-vp
committed
86087bc
Merging ThreadPoolBoundHandle.cs and ThreadPoolBoundHandle.Windows.cs
eduardo-vp
committed
cea582b
Renaming: RegisteredWaitHandle.cs to RegisteredWaitHandle.Windows.cs
eduardo-vp
committed
b97d175
Make threadLocalCompletionCountObject in ThreadPoolWorkQueue.cs nullable
eduardo-vp
committed
eb2c9fd
Merge branch 'main' into feature/enable-windows-threadpool
eduardo-vp
committed
fbc8a6e

Commits on May 19, 2023

Testing: disable trimming + enable windows threadpool by default
eduardo-vp
committed
a40bb4e
Add wrapper to WindowsThreadPool::DispatchCallback
eduardo-vp
committed
988d53f
Add xml to ThreadPoolBoundHandle::BindHandle
eduardo-vp
committed
fcb97c6
Merging ThreadPoolBoundHandle.Portable.cs with ThreadPoolBoundHandle.Unix.cs
eduardo-vp
committed
b9c462f
Renaming: ThreadPoolBoundHandle.Portable.Core.cs to ThreadPoolBoundHandle.Portable.cs
eduardo-vp
committed
f66a503
Removing IsWorkerTrackingEnabledInConfig from WindowsThreadPool class
eduardo-vp
committed
a769503
Refactor IsWorkerTrackingEnabledInConfig
eduardo-vp
committed
16cdae4
Refactor YieldFromDispatchLoop
eduardo-vp
committed
09b3f2e
Fix ThreadPool.Unix.cs
eduardo-vp
committed
45787e4
Update System.Private.CoreLib.Shared.projitems
eduardo-vp
committed
6d85f82
Renaming RegisteredWaitHandle files
eduardo-vp
committed
5288082
Fix System.Private.CoreLib.Shared.projitems
eduardo-vp
committed
db02dac
Renaming: PreAllocatedOverlapped.Portable.Core.cs to PreAllocatedOverlapped.Portable.cs
eduardo-vp
committed
78a9764

Commits on May 20, 2023

Commits on May 23, 2023

Fix BindHandlePortableCore
eduardo-vp
committed
e68c5b9
Unnecesarry checks in ThreadPoolBoundHandle.Unix.cs removed
eduardo-vp
committed
288c04d
Partial modified removed in ThreadPoolBoundHandle.Browser.Mono.cs
eduardo-vp
committed
2b4fdf5
Remove ReportThreadStatusCore
eduardo-vp
committed
c87c53b
Remove ThreadPool.Mono.cs
eduardo-vp
committed
cfb7b8b
Partial modified in ThreadPool.Browser.Mono.cs removed
eduardo-vp
committed
0c722a6
Partial modifier in PreAllocatedOverlapped.Browser.Mono.cs removed
eduardo-vp
committed
3b73bf2
ThreadPoolPreAllocatedOverlapped.WindowsThreadPool.cs renamed to PreAllocatedOverlapped.WindowsThreadPool.cs
eduardo-vp
committed
711546d
Place fields and properties from RegisteredWaitHandle.Windows.cs to the correct files
eduardo-vp
committed
d393fd5
Fix RegisteredWaitHandle on Unix
eduardo-vp
committed
dd02c79
Renamed ThreadPool.Portable.cs to ThreadPool.NonCoreCLR.cs
eduardo-vp
committed
afd1057
Add ReportThreadStatus to ThreadPool.Browser.Mono.cs
eduardo-vp
committed
24bb2df
Place XML on public methods
eduardo-vp
committed
3e51deb

Commits on May 24, 2023

Fix ThreadPoolCallbackWrapper
eduardo-vp
committed
7673336
Cache Thread.CurrentThread
eduardo-vp
committed
e6bbd3b
Set WorkerTracking to false when Windows thread pool is enabled
eduardo-vp
committed
8ea3735
Update comment on RegisteredWaitHandle::PerformCallbackWindowsThreadPool
eduardo-vp
committed
0c58c8b
Remove assertions in ThreadPoolBoundHandle::BindHandle
eduardo-vp
committed
b38ff77
Enable Windows thread pool timer
eduardo-vp
committed
71ea96f
Add Timer.WindowsThreadPool.cs only on Windows
eduardo-vp
committed
cbdbe58

Commits on May 25, 2023

Fix TimerQueue.Browser.Mono.cs
eduardo-vp
committed
ec6eebc
Fix browser buid
eduardo-vp
committed
d9d5802
Enable FeaturePortableTimer on NativeAot
eduardo-vp
committed
b519b17
Supress Finalizer on RegisteredWaitHandle
eduardo-vp
committed
6da6201
Throw argument exception in ThreadPoolBoundHandle.Unix.cs
eduardo-vp
committed
2acc143
Set UseWindowsThreadPool=true for testing
eduardo-vp
committed
7a5e7b7
Revert "Set UseWindowsThreadPool=true for testing"
eduardo-vp
committed
f8bf852
Enable trimming
eduardo-vp
committed
53521b8

Commits on May 26, 2023

Remove redundant assertions
eduardo-vp
committed
00fe833
Fix IsWorkerTrackingEnabledInConfig in ThreadPool.Windows.cs
eduardo-vp
committed
de39881
Update src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.Windows.cs

eduardo-vp
and
kouvel
authored
883d966

Commits on May 29, 2023

Commits on May 31, 2023

Enable Windows Threadpool tests
eduardo-vp
committed
cfc1fa1
Updated System.Threading.ThreadPool.sln
eduardo-vp
committed
51df61e
Remove MinimumVisualStudioVersion
eduardo-vp
committed
8c93a14
Set System.Threading.ThreadPool.UseWindowsThreadPool to false in System.Threading.ThreadPool.Tests.csproj
eduardo-vp
committed
059f1a1
Disable tests that call SetMinThreads/SetMaxThreads for WindowsThreadPool
eduardo-vp
committed
553f226
Disabling MetricTest() for Windows Threadpool
eduardo-vp
committed
156f7e5
Update src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPool.NonCoreCLR.cs

eduardo-vp
and
jkotas
authored
37c096a
Remove ThreadPool.NonCoreCLR.cs
eduardo-vp
committed
6064280

Commits on Jun 1, 2023

Remove conditions for YieldFromDispatchLoop in ThreadPool.Windows.cs
eduardo-vp
committed
14b3ff0
Removed EnsureConfigInitializedCore() in ThreadPool.Unix.cs
eduardo-vp
committed
01d7da3
Fix EnsureConfigInitialized()
eduardo-vp
committed
72c84b3
Updated EnsureConfigInitialized() to internal
eduardo-vp
committed
4471f52
Enabled Windows ThreadPool on Native AOT by default
eduardo-vp
committed
e887277
Added windows condition to UseWindowsThreadPool in Microsoft.NETCore.Native.targets
eduardo-vp
committed
21375a8
Fixed bug
eduardo-vp
committed
fd3e2f9
Fix bug in Microsoft.NETCore.Native.targets
eduardo-vp
committed
23ed1f2

Commits on Jun 2, 2023

Commits on Jun 5, 2023

Fixed InitializeForThreadPoolThread
eduardo-vp
committed
56be9f1

Commits on Jun 6, 2023

Commits on Jun 14, 2023

Merge with main + Fix conflicts
eduardo-vp
committed
117778c