Skip to content

Convert all EnC_SUPPORTED to FEATURE_ENC_SUPPORTED - #91035

Closed
AaronRobinsonMSFT wants to merge 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:align_enc_defines
Closed

Convert all EnC_SUPPORTED to FEATURE_ENC_SUPPORTED#91035
AaronRobinsonMSFT wants to merge 3 commits into
dotnet:mainfrom
AaronRobinsonMSFT:align_enc_defines

Conversation

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

No description provided.

@ghost

ghost commented Aug 23, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: 9.0.0

@mikelle-rogers mikelle-rogers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please inform me of the motivation behind this update?

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member Author

Would you please inform me of the motivation behind this update?

There were two defines for EnC support, EnC_SUPPORTED and FEATURE_ENC_SUPPORTED. This PR means there is now one. I chose the style with the FEATURE_ prefix that is now the version we use as opposed to the legacy version.

@AaronRobinsonMSFT
AaronRobinsonMSFT marked this pull request as ready for review August 24, 2023 15:29
@AaronRobinsonMSFT

Copy link
Copy Markdown
Member Author

This is a bit more complicated than I thought as there is some nuance here I was missing. I'm closing this PR as it is inappropriate.

@AaronRobinsonMSFT
AaronRobinsonMSFT deleted the align_enc_defines branch August 24, 2023 16:47
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants