Skip to content

JIT: Fix illegal operand swapping in VectorXYZ.AndNot transformation - #91882

Merged
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:fix-91855
Sep 11, 2023
Merged

JIT: Fix illegal operand swapping in VectorXYZ.AndNot transformation#91882
jakobbotsch merged 2 commits into
dotnet:mainfrom
jakobbotsch:fix-91855

Conversation

@jakobbotsch

Copy link
Copy Markdown
Member

The new logic introduced in #81993 would swap the LHS and RHS of the
operands without any additional checks for side effects.

Fix #91855

The new logic introduced in dotnet#81993 would swap the LHS and RHS of the
operands without any additional checks for side effects.

Fix dotnet#91855
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 11, 2023
@jakobbotsch jakobbotsch added this to the 9.0.0 milestone Sep 11, 2023
@ghost ghost assigned jakobbotsch Sep 11, 2023
@ghost

ghost commented Sep 11, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

The new logic introduced in #81993 would swap the LHS and RHS of the
operands without any additional checks for side effects.

Fix #91855

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@EgorBo EgorBo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point

@jakobbotsch
jakobbotsch merged commit 54a25d6 into dotnet:main Sep 11, 2023
@jakobbotsch
jakobbotsch deleted the fix-91855 branch September 11, 2023 20:03
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failed '!"Write to unaliased local overlaps outstanding read"' during 'Rationalize IR'

2 participants