[release/8.0] Manually update release/8.0 arcade to latest by lewing · Pull Request #92778 · dotnet/runtime

lewing · 2023-09-28T16:53:13Z

Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.

cc @ViktorHofer @mmitche

ghost · 2023-09-28T16:53:26Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.

cc @ViktorHofer

Author:	lewing
Assignees:	lewing
Labels:	`area-Infrastructure-libraries`
Milestone:	-

lewing · 2023-09-28T17:04:15Z

cc @ericstj

lewing · 2023-09-28T18:00:12Z

@sbomer I assume this is fixed via dotnet/sdk#35767 ?

sbomer · 2023-09-28T18:31:41Z

No, dotnet/sdk#35767 won't fix this instance because it was caused by setting <IsTrimmable>true</IsTrimmable> for a netstandard2.0-only project.

sbomer · 2023-09-28T18:50:03Z

Now seeing errors like

##[error]src/coreclr/tools/Common/TypeSystem/Ecma/SymbolReader/UnmanagedPdbSymbolReader.cs(287,67): error CS9191: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'ref' modifier for argument 2 corresponding to 'in' parameter is equivalent to 'in'. Consider using 'in' instead.

ghost · 2023-09-28T19:04:06Z

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Arcade flow is stuck somewhere in release/8.0 this the result of running darc update-dependencies --id 194643 manually.

cc @ViktorHofer @mmitche

Author:	lewing
Assignees:	lewing
Labels:	`blocking-release`, `area-Host`, `area-codeflow`
Milestone:	-

lewing · 2023-09-28T19:15:01Z

@elinor-fung are the host failures here rid related?

carlossanlop · 2023-09-28T20:57:27Z

 {
  "sdk": {
-    "version": "8.0.100-preview.7.23376.3",
+    "version": "8.0.100-rc.1.23455.8",


@lewing Should this be rtm? Also the one below.

Just asking because we've been doing similar manual adjustments in wasm flows. I don't know if it applies to this as well.

Not yet, we have to wait until we have an RTM SDK. I believe the arcade insertion is just doing it's thing propagating the arcade toolset changes here.

We'll need a newer sdk to be able to take the new roslyn in #92503 (comment) but this pr is just to catch us up with normal arcade flow

ericstj · 2023-09-28T21:03:34Z

I noticed we took the RC toolset update in 02bcb36. Among those other changes might be things needed here to update the toolset.

agocke · 2023-09-28T21:05:20Z

The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.

elinor-fung · 2023-09-28T21:23:23Z

The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.

This - win-x86/win-x64 - is what we have in main. (I'm also unclear as to what it is doing or what that comment means.)

ericstj · 2023-09-28T22:39:40Z

We don't have to do it in this PR, but I bet we can remove that RID. It looks to me like this dates back to 1.1 days where we had implementations in RID-specific packages. So in order to get NuGet to restore the right stuff to copy a RID that plugged into the graph was needed. b843687#diff-61c4029d873ebe0ce8a16d30a697127a7c96e11a1cc018936df1963aba0ef40bR12

And use the same condition as in main.

ViktorHofer · 2023-09-29T16:36:31Z

The problem is the src/tests/Common/external/external.csproj project. It specifies win7-x64 as a TFM. But it's even stranger because the comment says the RID doesn't even matter.
The whole thing smells of giant hacks, but I bet updating to win-x64 will fix the problem, even though I don't really know what's going on.

AFAIK, after the runtime tests are all migrated to the new source generated model (which should be completed soon), they will participate in NuGet restore and will get their dependencies directly, instead of via the external.csproj project. That project and setting a RID for restore will then go away.

lewing · 2023-09-29T18:16:52Z

So installer rid resolution failures left (other than CI noise)?

carlossanlop · 2023-10-04T16:00:48Z

@lewing @ViktorHofer do we need to address those rid-related CI failures in this PR, or should I open a separate issue to get them fixed?

ViktorHofer · 2023-10-04T17:30:40Z

Need to be addressed here. Those are real failures.

elinor-fung · 2023-10-05T21:25:25Z

_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63

Last commit ports over the below from main:

runtime/eng/Analyzers.targets

Lines 2 to 8 in 9dfbb61

    
             <PropertyGroup Condition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or 
        
                                       '$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or 
        
                                       '$(MSBuildProjectExtension)' == '.pkgproj' or 
        
                                       '$(UsingMicrosoftTraversalSdk)' == 'true'"> 
        
               <!-- Explicitly disable running analyzers to avoid trying to discover the correct ILLink tool pack for a project that has no sources. --> 
        
               <RunAnalyzers>false</RunAnalyzers> 
        
             </PropertyGroup>

carlossanlop

CI is green and the two remaining feedback items were addressed by @elinor-fung and @lewing. Merging now.

lewing · 2023-10-06T19:03:31Z

_RequiresILLinkPack ended up being true for packaging projects based on the single-file analyzer being enabled. As a result, this was trying to process framework references (it didn't before), which ended up adding those packages as download dependencies. https://github.com/dotnet/sdk/blob/4a1ffab37158144f8b1bc5995241b7ace7aa19ea/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L63

Last commit ports over the below from main:

runtime/eng/Analyzers.targets

Lines 2 to 8 in 9dfbb61

<PropertyGroup Condition="'$(UsingMicrosoftNoTargetsSdk)' == 'true' or

'$(UsingMicrosoftDotNetSharedFrameworkSdk)' == 'true' or

'$(MSBuildProjectExtension)' == '.pkgproj' or

'$(UsingMicrosoftTraversalSdk)' == 'true'">



<RunAnalyzers>false</RunAnalyzers>

</PropertyGroup>

Many thanks for resolving that.

Manually update release/8.0 arcade to latest

77aaab9

ghost added the area-Infrastructure-libraries label Sep 28, 2023

ghost assigned lewing Sep 28, 2023

lewing added area-codeflow for labeling automated codeflow and removed area-Infrastructure-libraries labels Sep 28, 2023

lewing requested review from ViktorHofer and mmitche September 28, 2023 16:58

lewing mentioned this pull request Sep 28, 2023

[release/8.0] Update dependencies from dotnet/roslyn #92503

Merged

build-analysis Bot mentioned this pull request Sep 28, 2023

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

5 tasks

lewing requested review from agocke, marek-safar and sbomer September 28, 2023 18:08

lewing added the blocking-release label Sep 28, 2023

Fix ILCompiler build

7d558f2

Fix analyzer warning

10ee724

lewing requested a review from MichalStrehovsky as a code owner September 28, 2023 18:51

lewing added the area-Host label Sep 28, 2023

lewing removed the area-Host label Sep 28, 2023

ericstj requested a review from carlossanlop September 28, 2023 20:54

carlossanlop reviewed Sep 28, 2023

View reviewed changes

carlossanlop added the Servicing-approved Approved for servicing release label Sep 28, 2023

work around rid issues

50738aa

ViktorHofer reviewed Sep 29, 2023

View reviewed changes

Comment thread src/coreclr/tools/aot/Directory.Build.props Outdated

sbomer and others added 2 commits September 29, 2023 15:27

Move to Directory.Build.targets

233e79a

And use the same condition as in main.

Merge branch 'release/8.0' into update-arcade-r8

83aeb50

This was referenced Sep 29, 2023

Tracking issue for CI build timeouts #76454

Closed

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Closed

lewing mentioned this pull request Oct 4, 2023

release/8.0 branch doesn't build with .NET 8 RC1 #93011

Closed

lewing added the area-Infrastructure-installer label Oct 5, 2023

build-analysis Bot mentioned this pull request Oct 5, 2023

Test infra failure on iOS.Device.Aot.Test.WorkItemExecution CI leg #92792

Closed

3 tasks

Set RunAnalyzers to false for projects with no sources

04c630b

Fix Microsoft.NETCore.App.deps.json to include RID graph

40907b0

carlossanlop approved these changes Oct 6, 2023

View reviewed changes

carlossanlop merged commit 0c2796c into dotnet:release/8.0 Oct 6, 2023

lewing deleted the update-arcade-r8 branch October 6, 2023 19:03

ghost locked as resolved and limited conversation to collaborators Nov 6, 2023

Uh oh!

Conversation

lewing commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Sep 28, 2023

Uh oh!

lewing commented Sep 28, 2023

Uh oh!

lewing commented Sep 28, 2023

Uh oh!

sbomer commented Sep 28, 2023

Uh oh!

sbomer commented Sep 28, 2023

Uh oh!

ghost commented Sep 28, 2023

Uh oh!

lewing commented Sep 28, 2023

Uh oh!

carlossanlop Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

carlossanlop Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

ericstj Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

lewing Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ericstj commented Sep 28, 2023

Uh oh!

agocke commented Sep 28, 2023

Uh oh!

elinor-fung commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericstj commented Sep 28, 2023

Uh oh!

Uh oh!

ViktorHofer commented Sep 29, 2023

Uh oh!

lewing commented Sep 29, 2023

Uh oh!

carlossanlop commented Oct 4, 2023

Uh oh!

ViktorHofer commented Oct 4, 2023

Uh oh!

elinor-fung commented Oct 5, 2023

Uh oh!

carlossanlop left a comment

Choose a reason for hiding this comment

Uh oh!

lewing commented Oct 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

lewing commented Sep 28, 2023 •

edited

Loading

lewing Sep 28, 2023 •

edited

Loading

elinor-fung commented Sep 28, 2023 •

edited

Loading