-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add --create-manifest-if-needed flag #31231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. The main thing still needed is to add test coverage.
src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallCommandParser.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Plaisted <[email protected]>
Co-authored-by: Daniel Plaisted <[email protected]>
Co-authored-by: Daniel Plaisted <[email protected]>
Co-authored-by: Daniel Plaisted <[email protected]>
Co-authored-by: Daniel Plaisted <[email protected]>
Per a discussion today, we may want to change the default so that you don't need to specify the |
@baronfel Was a final decision reached on this change? I believe we are going to go with what this PR does for now? There is the proposed In addition, regarding:
...
I assume that with the below stipulation, this means it's by default IFF the following is true?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few suggestions still.
src/Cli/dotnet/commands/dotnet-tool/install/LocalizableStrings.resx
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-tool/install/ToolInstallCommandParser.cs
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-tool/install/LocalizableStrings.resx
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Plaisted <[email protected]>
…Parser.cs Co-authored-by: Daniel Plaisted <[email protected]>
….resx Co-authored-by: Daniel Plaisted <[email protected]>
…Yue/sdk into 9500-dotnet-tool-installed
@JL03-Yue we need to doc this! I just went looking and couldn't find it. I'll make a docs issue and we can work on doing that. Logged dotnet/docs#39600 for this. |
#15254
Add
--create-manifest-if-needed
flagCreate tool manifest automatically when installing a new local tool if the flag is on and no manifest exists.