-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToolManifestFinder detect .slnx #47512
Merged
edvilme
merged 5 commits into
dotnet:release/9.0.3xx
from
edvilme:toolmanifestfinder-slnx
Mar 13, 2025
Merged
ToolManifestFinder detect .slnx #47512
edvilme
merged 5 commits into
dotnet:release/9.0.3xx
from
edvilme:toolmanifestfinder-slnx
Mar 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperk81
reviewed
Mar 12, 2025
Forgind
approved these changes
Mar 12, 2025
Rebasing to release/9.0.3xx as per @baronfel 's suggesions |
a76f628
to
b6fcbf0
Compare
This was referenced Mar 13, 2025
This was referenced Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
ToolManifestFinder.GetDirectoryToCreateToolManifest
to detect .slnx files in a directory, so that a tool manifest can be generated in that directory if the--create-manifest-if-needed
option is passedAddresses #40913 (comment)