Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolManifestFinder detect .slnx #47512

Merged
merged 5 commits into from
Mar 13, 2025

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Mar 12, 2025

Updates ToolManifestFinder.GetDirectoryToCreateToolManifest to detect .slnx files in a directory, so that a tool manifest can be generated in that directory if the --create-manifest-if-needed option is passed

Addresses #40913 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Tools untriaged Request triage from a team member labels Mar 12, 2025
@edvilme edvilme marked this pull request as ready for review March 12, 2025 17:12
@edvilme edvilme requested a review from a team March 12, 2025 17:12
@edvilme
Copy link
Member Author

edvilme commented Mar 12, 2025

Rebasing to release/9.0.3xx as per @baronfel 's suggesions

@edvilme edvilme force-pushed the toolmanifestfinder-slnx branch from a76f628 to b6fcbf0 Compare March 12, 2025 20:08
@edvilme edvilme requested review from a team and tmat as code owners March 12, 2025 20:08
@edvilme edvilme changed the base branch from release/9.0.2xx to release/9.0.3xx March 12, 2025 20:08
@edvilme edvilme removed request for a team and tmat March 12, 2025 20:23
@edvilme edvilme enabled auto-merge (squash) March 12, 2025 20:24
@edvilme edvilme merged commit 1a91572 into dotnet:release/9.0.3xx Mar 13, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Tools untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants