Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for updating version #47520

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

edvilme
Copy link
Member

@edvilme edvilme commented Mar 12, 2025

Extends #47474
Adds comment to make sure people updating the version of vs-solutionpersistence coordinate with other dependencies

@Copilot Copilot bot review requested due to automatic review settings March 12, 2025 21:58

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 12, 2025
@edvilme edvilme requested a review from a team March 12, 2025 21:58
@edvilme edvilme requested review from ViktorHofer and a team March 12, 2025 23:19
@nagilson
Copy link
Member

This is a good idea, it would be helpful for people who look this up in the future to be linked to the issue where this happened (the attached PR doesn't have the full context of this issue and how it presents itself if forgotten)

Co-authored-by: Noah Gilson <[email protected]>
@edvilme
Copy link
Member Author

edvilme commented Mar 13, 2025

This is a good idea, it would be helpful for people who look this up in the future to be linked to the issue where this happened (the attached PR doesn't have the full context of this issue and how it presents itself if forgotten)

It was from a bunch of codeflow prs from domestic cat. I can try looking them up again and linking them here, but I'm afraid it will be more confusing to people, what do you think?

@nagilson
Copy link
Member

I have no strong opinion either way, this should be enough context!

@edvilme edvilme enabled auto-merge (squash) March 13, 2025 20:37
@edvilme edvilme merged commit b3ca563 into dotnet:main Mar 13, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants