-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[browser/blazor] enable GenerateRuntimeConfigurationFiles #48916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modifies the Blazor WebAssembly SDK targets to conditionally disable the generation of runtime configuration files for Blazor projects until .NET 10. The changes include updating the element to include a condition based on the target framework version.
src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets
Outdated
Show resolved
Hide resolved
Thanks for your PR, @@pavelsavara. |
…6_0.targets Co-authored-by: Copilot <[email protected]>
|
@maraf please look again, I made few more changes |
@@ -20,7 +20,7 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
|
|||
<!-- General Properties --> | |||
<PropertyGroup> | |||
<ProjectAssetsFile Condition="'$(ProjectAssetsFile)' == ''">$(MSBuildProjectExtensionsPath)/project.assets.json</ProjectAssetsFile> | |||
<ProjectAssetsFile Condition="'$(ProjectAssetsFile)' == ''">$(MSBuildProjectExtensionsPath)project.assets.json</ProjectAssetsFile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change doesn't help us anyway, right?
Should we revert it and make in the build incrementalism tracking issue?
<!-- Turn off parts of the build that do not apply to Blazor projects --> | ||
<GenerateRuntimeConfigurationFiles>false</GenerateRuntimeConfigurationFiles> | ||
<!-- Turn off parts of the build that do not apply to Blazor projects until Net10 --> | ||
<GenerateRuntimeConfigurationFiles Condition="'$(GenerateRuntimeConfigurationFiles)' == '' and '$(_TargetingNETBefore100)' == 'true'">false</GenerateRuntimeConfigurationFiles> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<GenerateRuntimeConfigurationFiles Condition="'$(GenerateRuntimeConfigurationFiles)' == '' and '$(_TargetingNETBefore100)' == 'true'">false</GenerateRuntimeConfigurationFiles> | |
<GenerateRuntimeConfigurationFiles Condition="''$(_TargetingNETBefore100)' == 'true'">false</GenerateRuntimeConfigurationFiles> |
I think we should maintain the behavior from previous SDK when targeting downlevel versions
Contributes to dotnet/runtime#97449
Together with dotnet/runtime#115113
Filled for the broken incrementalism dotnet/runtime#115646