Skip to content

[release/9.0.1xx] Update dependencies from dotnet/arcade #48964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/9.0.1xx
Choose a base branch
from

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 14, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

…513.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.25263.2 -> To Version 9.0.0-beta.25263.5
@v-wuzhai
Copy link
Member

@dotnet/source-build Could you take a look at the failures here?

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented May 15, 2025

These are all NuGet Audit errors - @ViktorHofer do you know if these show up in repo builds in 9.0 branches?

Latest arcade CI or PR, 9.0, builds were on Tuesday, before the Audit errors were triggered. So, this explains why we have not seen this in arcade builds yet.

@ViktorHofer
Copy link
Member

ViktorHofer commented May 15, 2025

I'm not 100% sure which version of NuGet inserted into 9.0 but assuming it was 6.11, NuGetAudit is enabled by default for direct dependencies (not transitives): https://github.com/NuGet/NuGet.Client/blob/5469bd0d9de8108f15f21644759773b85471366c/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L71-L72

So any direct reference to i.e. the Microsoft.Build.Tasks.Core package that got marked as vulnerable yesterday will error.

@NikolaMilosavljevic
Copy link
Member

Errors are very similar to those seen in 10.0 branches, i.e.:

    /vmr/src/arcade/src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/Microsoft.DotNet.Build.Tasks.TargetFramework.csproj : error NU1901: Warning As Error: Package 'Microsoft.Build.Tasks.Core' 17.8.3 has a known low severity vulnerability, https://github.com/advisories/GHSA-h4j7-5rxr-p4wc [/vmr/src/arcade/Arcade.sln]
##[error]/vmr/src/arcade/src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/Microsoft.DotNet.Build.Tasks.TargetFramework.csproj(0,0): error NU1901: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Package 'Microsoft.Build.Tasks.Core' 17.8.3 has a known low severity vulnerability, https://github.com/advisories/GHSA-h4j7-5rxr-p4wc
    /vmr/src/arcade/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj : error NU1901: Warning As Error: Package 'Microsoft.Build.Tasks.Core' 17.8.3 has a known low severity vulnerability, https://github.com/advisories/GHSA-h4j7-5rxr-p4wc [/vmr/src/arcade/Arcade.sln]
##[error]/vmr/src/arcade/src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj(0,0): error NU1901: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Package 'Microsoft.Build.Tasks.Core' 17.8.3 has a known low severity vulnerability, https://github.com/advisories/GHSA-h4j7-5rxr-p4wc

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented May 15, 2025

Arcade uses packages from SBRP, version 17.8.3, which is considered vulnerable. Next up, in the same range, that isn't vulnerable is 17.8.29. I'll produce SBRP packages and flow them to arcade, so the version can be updated. This should eventually resolve the issue.

@NikolaMilosavljevic
Copy link
Member

I've merged the fix in arcade repo - dotnet/arcade#15843. It should be picked up by this flow after successful build. That should resolve the source-build issue.

@NikolaMilosavljevic
Copy link
Member

I've triggered the arcade->sdk flow for 9.0.1xx - it should update this PR shortly and start a rerun of the checks.

…516.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 9.0.0-beta.25263.2 -> To Version 9.0.0-beta.25266.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants