Shutdown build servers via named pipes #50429
Conversation
|
This PR is targeting |
| // NOTE: This modifies the permissions if needed, and throws if not possible. | ||
| Directory.CreateDirectory(path, UnixFileMode.UserRead | UnixFileMode.UserWrite | UnixFileMode.UserExecute); |
There was a problem hiding this comment.
The comment there looks misleading.
If the directory exists already, then CreateDirectory ignores the UnixFileMode, except throws if the argument contains undefined bits.
If the directory does not exist yet, then CreateDirectory passes the UnixFileMode to the mkdir system call, which uses it when creating the directory. But the umask of the process may cause mkdir not to grant all the permissions listed in the UnixFileMode. That would be the user's misconfiguration though; it is not reasonable to expect programs to work if the umask prevents permissions from being granted to the user.
There was a problem hiding this comment.
Thanks, that's indeed not what I've expected. But I think the behavior is acceptable, I will just update the comment.
No description provided.