Remove FileLoggersCount from MSBuild telemetry event #50432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is related to SerialConsoleLogger deprecation: dotnet/msbuild#12336
There was a problem hiding this comment.
Pull Request Overview
This PR removes the FileLoggersCount property from the MSBuild logging configuration telemetry event. The change supports the deprecation of SerialConsoleLogger in MSBuild, as the system will now operate exclusively with parallel loggers by default, making the file logger count metric obsolete.
- Removes
FileLoggersCountfrom telemetry measurements for logging configuration events
|
This PR is targeting |
YuliiaKovalova
changed the title
|
@baronfel could you please review? |
baronfel
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is related to SerialConsoleLogger deprecation: dotnet/msbuild#12336
The property isn't needed anymore, since MSBuild will be operating on parallel logger only by default.