-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove directory option in dotnet test #50434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mariam-abdulla
merged 12 commits into
release/10.0.1xx
from
dev/mabdullah/remove-directory-option-in-dotnet-test
Aug 25, 2025
Merged
Remove directory option in dotnet test #50434
mariam-abdulla
merged 12 commits into
release/10.0.1xx
from
dev/mabdullah/remove-directory-option-in-dotnet-test
Aug 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
approved these changes
Aug 25, 2025
Youssef1313
reviewed
Aug 25, 2025
@@ -115,42 +115,40 @@ public void RunWithInvalidProjectExtension_ShouldReturnExitCodeGenericFailure(st | |||
|
|||
[InlineData(TestingConstants.Debug)] | |||
[InlineData(TestingConstants.Release)] | |||
[Theory] | |||
public void RunWithInvalidSolutionExtension_ShouldReturnExitCodeGenericFailure(string configuration) | |||
[PlatformSpecificTheory(TestPlatforms.Any & ~TestPlatforms.OSX)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not working on macOS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the
dotnet test
CLI command handles directory inputs, removing the--directory
option and improving project/solution file resolution logic. The changes simplify the user experience by allowing directories to be passed to--project
or--solution
and enhance ambiguity handling when multiple project files are present. Validation and error messaging have also been updated to reflect these improvements.Command-line interface and options:
--directory
option from the CLI, parser, and options definitions, so directories should now be specified using--project
or--solution
. [1] [2] [3]Project and solution resolution logic:
MSBuildHandler
to distinguish between directory and file inputs for project/solution options, using new helper methods to resolve the correct file when a directory is given. [1] [2]TryGetProjectFilePath
andTryGetSolutionFilePath
methods inSolutionAndProjectUtility
to handle directories and resolve ambiguities when multiple project files are present. [1] [2]Validation improvements:
--project
/--solution
and provide more accurate error messages. [1] [2]--directory
option. [1] [2]General code cleanup:
using
statements and simplified some type references for clarity and consistency. [1] [2] [3] [4]Fixes #50325