Skip to content

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Aug 22, 2025

Including the state of global.json in telemetry events for SDK commands.

Resolves #50058

cc @dotnet/appmodel @AaronRobinsonMSFT @richlander

@elinor-fung elinor-fung requested a review from a team August 22, 2025 18:59
@elinor-fung
Copy link
Member Author

@dotnet/dotnet-cli Is there a good way to locally view the telemetry events that actually get sent? I debugged through to make sure the event is created with the new property, but I don't know how to test beyond that.

@dsplaisted dsplaisted requested a review from baronfel August 22, 2025 21:22
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems like this is adding a separate event for the global.json state, I'm not sure if that's best or if it would be better to add the global.json state to an existing event.

@baronfel can probably suggest how you can validate the telemetry sent locally.

@elinor-fung
Copy link
Member Author

It seems like this is adding a separate event for the global.json state, I'm not sure if that's best or if it would be better to add the global.json state to an existing event.

My intent was to add a property to an existing event (toplevelparser/command). I believe that is what this is doing by adding to the properties of the ApplicationInsightsEntryFormat that gets created, but I could be confused.

@baronfel
Copy link
Member

@elinor-fung's glomming onto the toplevelparser/command event correctly, it's just a bit weird of a semantic that we have there. I don't really like it, but we haven't revamped it yet.

you basically can't easily verify the telemetry locally. when we add Otel that will change and it'll become trivially verifiable, but that won't happen until after 10 GA sometime.

@baronfel baronfel merged commit c392257 into dotnet:release/10.0.1xx Aug 23, 2025
27 checks passed
@baronfel
Copy link
Member

baronfel commented Aug 23, 2025

Once a new build comes out we can check the GDPR classifications for this new data point. We'll need to add it to the existing telemetry docs.

@marcpopMSFT
Copy link
Member

Once a new build comes out we can check the GDPR classifications for this new data point. We'll need to add it to the existing telemetry docs.

@baronfel I've done the classification. Who owns doing the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants