Add Razor Diagnostic Test #8266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
May 8, 2025
| await testAssetWorkspace.cleanupWorkspace(); | ||
| }); | ||
|
|
||
| test('CSharp Diagnostics', async () => { |
There was a problem hiding this comment.
Nit: This is a "CSharp and Razor Diagnostics" test
| expect(diagnostics[0].range).toStrictEqual(new vscode.Range(2, 0, 2, 25)); | ||
| expect(diagnostics[0].source).toBe('Razor'); | ||
|
|
||
| expect(diagnostics[1].message).toBe("The name 'Message' does not exist in the current context"); |
There was a problem hiding this comment.
Why not validate the C# diagnostic code too? Would confirm we're sending it through correctly etc.
There was a problem hiding this comment.
Let me add that. I wasn't sure how to do it because it's a weird definition but I think I can use toStrictEqual and achieve that
There was a problem hiding this comment.
Oh, it's not the same as the Razor one above? That's interesting...
There was a problem hiding this comment.
Yea, it's a code + uri
auto-merge was automatically disabled
June 19, 2025 23:53
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.