Upgrade the LSP client library for better logging support #8281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
force-pushed
the
use-loggeroutputchannel
branch
from
da1bf73 to
e7eae1b
Compare
dibarbet
reviewed
May 12, 2025
jasonmalinowski
force-pushed
the
use-loggeroutputchannel
branch
from
e7eae1b to
e3d98c0
Compare
dibarbet
approved these changes
Aug 6, 2025
10.0.0-next.15 brings full support for LogOutputChannels which cleans up the logging of severities and timestamps. Otherwise we end up with confusing duplicate severities being listed with duplicate timestamps.
Prior to moving things to LogOutputChannels, we implicitly controlled the log level of the LSP traces by the log level of our main output channel: as long as that was debug or trace, we'd also output the LSP traces. Now each channel behaves independently, with the requirement that if you want LSP tracing, you must set the trace channel to 'trace' level. The other settings don't do anything.
jasonmalinowski
force-pushed
the
use-loggeroutputchannel
branch
from
e3d98c0 to
6d28b76
Compare
dibarbet
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10.0.0-next.15 brings full support for LogOutputChannels which cleans up the logging of severities and timestamps. Otherwise we end up with confusing duplicate severities being listed with duplicate timestamps.
This support was added in microsoft/vscode-languageserver-node#1630.