Skip to content

Add test coverage for DateTimePicker #11033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

John-Qiao
Copy link
Contributor

@John-Qiao John-Qiao commented Mar 12, 2024

related #10453

Proposed changes

Add unit tests for DateTimePicker's property and event

  • Properties:
  1. CalendarTitleBackColor

  2. CalendarForeColor

  3. CalendarTitleForeColor

  4. CalendarTrailingForeColor

  5. CalendarMonthBackground

  • Events:
  1. BackColorChanged

  2. BackgroundImageChanged

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

@John-Qiao John-Qiao requested a review from a team as a code owner March 12, 2024 09:16
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.23479%. Comparing base (bd97476) to head (309d767).
Report is 49 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11033         +/-   ##
===================================================
+ Coverage   73.17333%   73.23479%   +0.06145%     
===================================================
  Files           3097        3096          -1     
  Lines         633955      633692        -263     
  Branches       47364       47336         -28     
===================================================
+ Hits          463886      464083        +197     
+ Misses        166522      166068        -454     
+ Partials        3547        3541          -6     
Flag Coverage Δ
Debug 73.23479% <100.00000%> (+0.06145%) ⬆️
integration 18.42694% <ø> (-0.02383%) ⬇️
production 46.72867% <ø> (+0.05459%) ⬆️
test 94.98054% <100.00000%> (+0.00600%) ⬆️
unit 43.60773% <ø> (+0.06247%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Olina-Zhang Olina-Zhang self-requested a review March 12, 2024 10:00
@LeafShi1
Copy link
Member

@lonitra Please help review this PR

@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Mar 15, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Mar 18, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit 4ab58b0 into dotnet:main Mar 20, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants