Skip to content

Update the Update_ToolStripPanelControlCollection_XYCompareTestsFiler… #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Jan 9, 2025

related #10453

Proposed changes

Update the Update_ToolStripPanelControlCollection_XYCompareTestsFile to let the test class inherit from the IDisposable interface.

Microsoft Reviewers: Open in CodeFlow

… that let the test class inherit from the IDisposable interface.
@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner January 9, 2025 01:23
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though there are failing checks, they're clearly not caused by the PR's code. LGTM!

@Tanya-Solyanik
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.15488%. Comparing base (ce6b6c2) to head (23bd48c).
Report is 12 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12736         +/-   ##
===================================================
+ Coverage   76.14673%   76.15488%   +0.00815%     
===================================================
  Files           3191        3192          +1     
  Lines         640105      640458        +353     
  Branches       47233       47339        +106     
===================================================
+ Hits          487419      487740        +321     
- Misses        149166      149206         +40     
+ Partials        3520        3512          -8     
Flag Coverage Δ
Debug 76.15488% <ø> (+0.00815%) ⬆️
integration 18.18310% <ø> (+0.01287%) ⬆️
production 50.08550% <ø> (+0.03331%) ⬆️
test 97.02792% <ø> (+0.00029%) ⬆️
unit 47.29529% <ø> (+0.03401%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik
Copy link
Contributor

related #10453

Proposed changes
Update the Update_ToolStripPanelControlCollection_XYCompareTestsFile to let the test class inherit from the IDisposable interface.

@Tanya-Solyanik Tanya-Solyanik merged commit 31ab37c into dotnet:main Jan 10, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 10, 2025
@Zheng-Li01 Zheng-Li01 deleted the Update_ToolStripPanelControlCollection_XYCompareTestsFiler branch January 13, 2025 01:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants