-
Notifications
You must be signed in to change notification settings - Fork 1k
Add code coverage for DataGridViewColumnConverter #12766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tanya-Solyanik
merged 3 commits into
dotnet:main
from
Zheng-Li01:Add_code_coverage_for_DataGridViewColumnConverter
Jan 16, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
88 changes: 88 additions & 0 deletions
88
...em.Windows.Forms/tests/UnitTests/System/Windows/Forms/DataGridViewColumnConverterTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
#nullable enable | ||
|
||
using System.ComponentModel.Design.Serialization; | ||
using System.Globalization; | ||
|
||
namespace System.Windows.Forms.Tests; | ||
|
||
public class DataGridViewColumnConverterTests : IDisposable | ||
{ | ||
private readonly DataGridViewColumnConverter _converter = new(); | ||
private readonly DataGridViewColumn _column = new(); | ||
|
||
public void Dispose() => _column.Dispose(); | ||
|
||
[Theory] | ||
[InlineData(typeof(InstanceDescriptor))] | ||
[InlineData(typeof(string))] | ||
public void CanConvertTo_ReturnsExpectedResult(Type destinationType) => | ||
_converter.CanConvertTo(context: null, destinationType).Should().BeTrue(); | ||
|
||
[Fact] | ||
public void ConvertTo_InstanceDescriptorWithoutCellType_ReturnsInstanceDescriptor() => | ||
AssertInstanceDescriptor(_column); | ||
|
||
[Fact] | ||
public void ConvertTo_InstanceDescriptorWithHeaderText_ReturnsInstanceDescriptor() | ||
{ | ||
_column.HeaderText = "Test Header"; | ||
AssertInstanceDescriptor(_column); | ||
} | ||
|
||
[Fact] | ||
public void ConvertTo_InstanceDescriptorWithToolTipText_ReturnsInstanceDescriptor() | ||
{ | ||
_column.ToolTipText = "Test ToolTip"; | ||
AssertInstanceDescriptor(_column); | ||
} | ||
|
||
[Fact] | ||
public void ConvertTo_NonInstanceDescriptorWithDataPropertyName_ReturnsBaseResult() | ||
{ | ||
_column.DataPropertyName = "TestDataProperty"; | ||
AssertBaseResult(_column); | ||
} | ||
|
||
[Fact] | ||
public void ConvertTo_NonInstanceDescriptor_ReturnsBaseResult() => | ||
AssertBaseResult(_column); | ||
|
||
[Fact] | ||
public void ConvertTo_NullDestinationType_ThrowsArgumentNullException() | ||
{ | ||
Action action = () => _converter.ConvertTo(context: null, culture: CultureInfo.InvariantCulture, value: _column, destinationType: null!); | ||
action.Should().Throw<ArgumentNullException>(); | ||
} | ||
|
||
[Fact] | ||
public void ConvertTo_InvalidDestinationType_ThrowsNotSupportedException() | ||
{ | ||
Action action = () => _converter.ConvertTo(context: null, culture: CultureInfo.InvariantCulture, value: _column, destinationType: typeof(int)); | ||
action.Should().Throw<NotSupportedException>(); | ||
} | ||
|
||
[Fact] | ||
public void ConvertTo_WithCellTypeNotNull_ReturnsInstanceDescriptor() | ||
{ | ||
using DataGridViewTextBoxCell cellTemplate = new(); | ||
using DataGridViewColumn column = new(cellTemplate); | ||
|
||
var descriptor = _converter.ConvertTo(context: null, culture: CultureInfo.InvariantCulture, value: column, destinationType: typeof(InstanceDescriptor)) as InstanceDescriptor; | ||
|
||
descriptor.Should().NotBeNull(); | ||
} | ||
|
||
private void AssertInstanceDescriptor(DataGridViewColumn column) | ||
{ | ||
var descriptor = _converter.ConvertTo(context: null, culture: CultureInfo.InvariantCulture, value: column, destinationType: typeof(InstanceDescriptor)) as InstanceDescriptor; | ||
descriptor.Should().NotBeNull(); | ||
} | ||
|
||
private void AssertBaseResult(DataGridViewColumn column) | ||
{ | ||
_converter.ConvertTo(context: null, culture: CultureInfo.InvariantCulture, value: column, destinationType: typeof(string)).Should().Be(column.ToString()); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.