Skip to content

Add unit test for WebBrowserProgressChangedEventArgs #12778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

chaowendy
Copy link
Contributor

@chaowendy chaowendy commented Jan 14, 2025

related #10453

Proposed changes

  • Add unit tests for WebBrowserProgressChangedEventArgs.cs to test its constructor and the properties CurrentProgress and MaximumProgress
Microsoft Reviewers: Open in CodeFlow

@chaowendy chaowendy requested a review from a team as a code owner January 14, 2025 07:35
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02376%. Comparing base (099da73) to head (f6e22f3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #12778          +/-   ##
====================================================
+ Coverage   76.18936%   97.02376%   +20.83440%     
====================================================
  Files           3194        1198        -1996     
  Lines         640365      355885      -284480     
  Branches       47239        5463       -41776     
====================================================
- Hits          487890      345293      -142597     
+ Misses        148951        9783      -139168     
+ Partials        3524         809        -2715     
Flag Coverage Δ
Debug 97.02376% <100.00000%> (+20.83440%) ⬆️
integration ?
production ?
test 97.02376% <100.00000%> (-0.00043%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.


[WinFormsFact]
public void Constructor_ShouldSetPropertiesCorrectly()
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 test look like is duplicated and it has been cover by test

public void Ctor_Long_Long(long currentProgress, long maximumProgress)

@chaowendy
Copy link
Contributor Author

Duplicated

@chaowendy chaowendy closed this Jan 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants