Adds some specific serialization test cases for the ToolStripMenuItemCodeDomSerializer class
#13200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardobossan
added
the
waiting-review
There was a problem hiding this comment.
Pull Request Overview
This PR adds new unit tests for the ToolStripMenuItemCodeDomSerializer class to ensure specific serialization behaviors for drop-down items, enabled state, checked status & text, and image properties.
- Adds test case for serializing drop-down items.
- Adds test case for serializing the Enabled property.
- Adds test cases for serializing Checked, Text, and Image properties.
…mCodeDomSerializer` class Related dotnet#10773 Related dotnet#12883 - After the merging of dotnet#12883, [there was a request](dotnet#12883 (comment)) for some specific serialization test cases of the `ToolStripMenuItemCodeDomSerializer` class. - Adds some specific serialization test cases for the `ToolStripMenuItemCodeDomSerializer` class. - None - Minimal - Unit tests - 10.0.100-preview.3.25167.3
ricardobossan
force-pushed
the
Adds_Specific_Serialization_Test_Cases_To_ToolStripMenuItemCodeDomSerializer
branch
from
a9c4ecb to
1cd5d8b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13200 +/- ##
===================================================
+ Coverage 61.42016% 61.54850% +0.12833%
===================================================
Files 1548 1549 +1
Lines 158588 158670 +82
Branches 14758 14763 +5
===================================================
+ Hits 97405 97659 +254
+ Misses 60480 60304 -176
- Partials 703 707 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
LeafShi1
reviewed
Mar 31, 2025
...esign/tests/UnitTests/System/Windows/Forms/Design/ToolStripMenuItemCodeDomSerializerTests.cs
Outdated
Show resolved
Hide resolved
...esign/tests/UnitTests/System/Windows/Forms/Design/ToolStripMenuItemCodeDomSerializerTests.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
waiting-author-feedback
ricardobossan
added
waiting-review
Tanya-Solyanik
added
area-test coverage
and removed
waiting-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Related #12883
Root Cause
ToolStripMenuItemCodeDomSerializerclass.Proposed changes
ToolStripMenuItemCodeDomSerializerclass.Customer Impact
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow