-
Notifications
You must be signed in to change notification settings - Fork 1k
Add code coverage for ToolStripContainerActionList #13256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage for ToolStripContainerActionList #13256
Conversation
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13256 +/- ##
====================================================
- Coverage 75.97321% 62.53133% -13.44188%
====================================================
Files 3265 1560 -1705
Lines 643286 159616 -483670
Branches 47431 14900 -32531
====================================================
- Hits 488725 99810 -388915
+ Misses 150991 59039 -91952
+ Partials 3570 767 -2803
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs:163
- [nitpick] The expected display name 'Dock Fill in Form' in this test seems inconsistent with the 'Dock in Form' string used in another test. Consider aligning the naming conventions between tests for clarity and consistency.
displayNames.Should().ContainSingle(name => name == "Dock Fill in Form");
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a little advice
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Outdated
Show resolved
Hide resolved
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Outdated
Show resolved
Hide resolved
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Outdated
Show resolved
Hide resolved
…/Forms/Design/ToolStripContainerActionListTests.cs
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Outdated
Show resolved
Hide resolved
…/Forms/Design/ToolStripContainerActionListTests.cs
...orms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs
Outdated
Show resolved
Hide resolved
…/Forms/Design/ToolStripContainerActionListTests.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good, please keep lines under the 120 chars limit.
src\System.Windows.Forms.Design\tests\UnitTests\System\Windows\Forms\Design\ToolStripContainerActionListTests.cs(160,50): error SA1028: (NETCORE_ENGINEERING_TELEMETRY=Build) Code should not contain trailing whitespace |
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow