Skip to content

Add code coverage for ToolStripContainerActionList #13256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 16, 2025

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented Apr 7, 2025

Related #10773

Proposed changes

  • Add unit test ToolStripContainerActionListTests.cs for public properties and method of the ToolStripContainerActionList.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 97.10145% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.53133%. Comparing base (8ef1b9c) to head (9dfcc8e).
Report is 285 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13256          +/-   ##
====================================================
- Coverage   75.97321%   62.53133%   -13.44188%     
====================================================
  Files           3265        1560        -1705     
  Lines         643286      159616      -483670     
  Branches       47431       14900       -32531     
====================================================
- Hits          488725       99810      -388915     
+ Misses        150991       59039       -91952     
+ Partials        3570         767        -2803     
Flag Coverage Δ
Debug 62.53133% <97.10145%> (-9.92093%) ⬇️
integration 11.31915% <ø> (-6.69302%) ⬇️
production 40.70707% <ø> (-9.15860%) ⬇️
test 95.68655% <97.10145%> (-1.40762%) ⬇️
unit 38.10048% <ø> (-9.22454%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardobossan ricardobossan requested a review from Copilot April 8, 2025 02:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripContainerActionListTests.cs:163

  • [nitpick] The expected display name 'Dock Fill in Form' in this test seems inconsistent with the 'Dock in Form' string used in another test. Consider aligning the naming conventions between tests for clarity and consistency.
displayNames.Should().ContainSingle(name => name == "Dock Fill in Form");

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Apr 8, 2025
@Tanya-Solyanik Tanya-Solyanik requested a review from LeafShi1 April 8, 2025 16:52
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a little advice

@Syareel-Sukeri Syareel-Sukeri added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Apr 14, 2025
ricardobossan
ricardobossan previously approved these changes Apr 14, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

…/Forms/Design/ToolStripContainerActionListTests.cs
…/Forms/Design/ToolStripContainerActionListTests.cs
…/Forms/Design/ToolStripContainerActionListTests.cs
Tanya-Solyanik
Tanya-Solyanik previously approved these changes Apr 16, 2025
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good, please keep lines under the 120 chars limit.

@Tanya-Solyanik Tanya-Solyanik enabled auto-merge (squash) April 16, 2025 00:37
@Tanya-Solyanik Tanya-Solyanik added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Apr 16, 2025
@LeafShi1
Copy link
Member

src\System.Windows.Forms.Design\tests\UnitTests\System\Windows\Forms\Design\ToolStripContainerActionListTests.cs(160,50): error SA1028: (NETCORE_ENGINEERING_TELEMETRY=Build) Code should not contain trailing whitespace

@Tanya-Solyanik Tanya-Solyanik merged commit 6b3acda into dotnet:main Apr 16, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 16, 2025
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Apr 16, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants