Skip to content

Add code coverage for ListViewGroupCollectionEditor #13275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Apr 9, 2025

Related #10773

Proposed changes

Add unit test file: ListViewGroupCollectionEditorTests.cs for public methods of the ListViewGroupCollectionEditor.cs

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.20616%. Comparing base (378a836) to head (6b1c0ab).
Report is 25 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13275         +/-   ##
===================================================
+ Coverage   62.09218%   62.20616%   +0.11397%     
===================================================
  Files           1555        1557          +2     
  Lines         159260      159399        +139     
  Branches       14849       14861         +12     
===================================================
+ Hits           98888       99156        +268     
+ Misses         59648       59492        -156     
- Partials         724         751         +27     
Flag Coverage Δ
Debug 62.20616% <100.00000%> (+0.11397%) ⬆️
integration 11.29955% <ø> (+0.57611%) ⬆️
production 40.33961% <ø> (+0.13795%) ⬆️
test 95.66950% <100.00000%> (+0.00321%) ⬆️
unit 37.69657% <ø> (+0.04357%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardobossan ricardobossan added waiting-author-feedback The team requires more information from the author waiting-review This item is waiting on review by one or more members of team labels Apr 10, 2025
@Zheng-Li01 Zheng-Li01 removed the waiting-author-feedback The team requires more information from the author label Apr 10, 2025
ricardobossan
ricardobossan previously approved these changes Apr 10, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback and removed waiting-review This item is waiting on review by one or more members of team labels Apr 10, 2025
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Apr 11, 2025
@ricardobossan
Copy link
Member

Thank you!

Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 935d62d into dotnet:main Apr 16, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview4 milestone Apr 16, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Apr 16, 2025
@Zheng-Li01 Zheng-Li01 deleted the Add_code_coverage_for_ListViewGroupCollectionEditor branch April 17, 2025 00:57
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants