-
Notifications
You must be signed in to change notification settings - Fork 1k
Add code coverage for ListViewDesigner #13301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage for ListViewDesigner #13301
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13301 +/- ##
===================================================
+ Coverage 62.19645% 62.55644% +0.35999%
===================================================
Files 1556 1560 +4
Lines 159366 159675 +309
Branches 14854 14904 +50
===================================================
+ Hits 99120 99887 +767
+ Misses 59495 59019 -476
- Partials 751 769 +18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewDesignerTests.cs:107
- [nitpick] The test 'ListViewDesigner_Initialize_HooksChildHandles_WhenViewIsDetails' only asserts that the designer instance is not null, which does not verify that child handles are actually hooked. It is recommended to add assertions that check for specific properties or events that confirm the child handles have been hooked when the view is set to Details.
public void ListViewDesigner_Initialize_HooksChildHandles_WhenViewIsDetails()
src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewDesignerTests.cs:117
- [nitpick] The test 'ListViewDesigner_Initialize_DoesNotHookChildHandles_WhenViewIsNotDetails' only asserts that the designer instance is not null. It would be more effective to verify that no child handle-related actions occur when the view is not set to Details.
public void ListViewDesigner_Initialize_DoesNotHookChildHandles_WhenViewIsNotDetails()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than small comments, LGTM!
...em.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewDesignerTests.cs
Outdated
Show resolved
Hide resolved
...em.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ListViewDesignerTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Nice catch that this file was in a wrong folder.
Related #10773
Proposed changes
Add unit test file: ListViewDesignerrTests.cs for public methods & properties of the ListViewDesigner.cs
Microsoft Reviewers: Open in CodeFlow