-
Notifications
You must be signed in to change notification settings - Fork 1k
Enable nullability for ToolStripTemplateNode
#13401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable nullability for ToolStripTemplateNode
#13401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request enables nullable annotations on ToolStripTemplateNode and updates its related code to support nullability. Key changes include:
- Removal of "#nullable disable" and updating field types with nullable annotations
- Adjustments to method signatures and null-check logic using null-conditional operations
- Updates to castings and service retrieval patterns to accommodate potential null values
@LeafShi1 - this PR got labeled as 'area: NRT' by 2 tools, by https://github.com/dotnet/winforms/blob/main/.github/policies/resourceManagement.yml and by https://github.com/dotnet/winforms/blob/main/.github/workflows/labeler-predict-pulls.yml, could you please remove the rule that adds this label from the resourceManagement bot? |
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripTemplateNode.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripTemplateNode.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13401 +/- ##
===================================================
- Coverage 62.72868% 62.72004% -0.00864%
===================================================
Files 1561 1562 +1
Lines 159997 160027 +30
Branches 14918 14960 +42
===================================================
+ Hits 100364 100369 +5
- Misses 58856 58883 +27
+ Partials 777 775 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
@LeafShi1 - could you please factor out the bot fix to merge it ASAP? I have concerns about the nullability changes, I feel that |
Revert the changes in resourceManagement.yml and put it in a separate PR #13417 |
864eb5e
to
cb9f820
Compare
Enable nullability for
ToolStripTemplateNode
Microsoft Reviewers: Open in CodeFlow