Skip to content

Add code coverage for DesignerUtils #13435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented May 9, 2025

Related #10773

Proposed changes
Add unit test file: DesignerUtilsTests.cs for public methods & properties of the DesignerUtils.cs

Note: working on another PR for the remaining test case

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.61456%. Comparing base (71a8e95) to head (2887987).
Report is 7 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13435         +/-   ##
===================================================
+ Coverage   76.60371%   76.61456%   +0.01084%     
===================================================
  Files           3230        3230                 
  Lines         639097      639184         +87     
  Branches       47289       47289                 
===================================================
+ Hits          489572      489708        +136     
+ Misses        145953      145909         -44     
+ Partials        3572        3567          -5     
Flag Coverage Δ
Debug 76.61456% <100.00000%> (+0.01084%) ⬆️
integration 18.78983% <ø> (+0.00174%) ⬆️
production 51.02813% <ø> (+0.01709%) ⬆️
test 97.40475% <100.00000%> (+0.00064%) ⬆️
unit 48.40965% <ø> (-0.00942%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label May 9, 2025
@ricardobossan ricardobossan requested a review from Copilot May 9, 2025 21:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds code coverage for the public methods and properties of DesignerUtils by introducing a new unit test file. Key changes include:

  • Tests for applying theme styles for ListView and TreeView.
  • Tests for filtering generic types and obtaining unique site names.
  • Multiple tests verifying bounds and text baseline calculations in various scenarios.

ricardobossan

This comment was marked as outdated.

@ricardobossan ricardobossan dismissed their stale review May 9, 2025 21:48

Copilot had a point

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label May 9, 2025
@Zheng-Li01 Zheng-Li01 removed the waiting-author-feedback The team requires more information from the author label May 12, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test coverage waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants