Skip to content

Unify DesignSurface and TestConsole into DemoConsole #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricardobossan
Copy link
Member

@ricardobossan ricardobossan commented May 9, 2025

Fixes #13388

Proposed changes

  • Renamed files in DesignSurfaceExt to match the updated class names from PR Unify namespaces and class names under DemoConsole #13433
  • Moved all code files from DesignSurfaceExt into the DemoConsole project directory
  • Integrated all relevant configuration from DesignSurfaceExt.csproj into DemoConsole.csproj
  • Deleted DesignSurfaceExt.csproj
  • Merged the contents of Directory.Build.props into DemoConsole.csproj to consolidate all settings in one place
  • Removed the now redundant Directory.Build.props file
  • Relocated the DemoConsole folder up one level to align with other integration test projects
  • Deleted the now empty DesignSurfaceExt folder

Customer Impact

  • None

Risk

  • Minimal

Test methodology

  • Manual

Test environment(s)

  • 10.0.100-preview.3.25201.16
Microsoft Reviewers: Open in CodeFlow

Fixes dotnet#13338

## Proposed changes

- Renamed files in `DesignSurfaceExt` to match the updated class names
from PR dotnet#13433
- Moved all code files from `DesignSurfaceExt` into the `DemoConsole`
project directory
- Integrated all relevant configuration from `DesignSurfaceExt.csproj`
into `DemoConsole.csproj`
- Deleted `DesignSurfaceExt.csproj`
- Merged the contents of `Directory.Build.props` into
`DemoConsole.csproj` to consolidate all settings in one place
- Removed the now redundant `Directory.Build.props` file
- Relocated the `DemoConsole` folder up one level to align with other
integration test projects
- Deleted the now empty `DesignSurfaceExt` folder

## Customer Impact

- None

## Risk

- Minimal

## Test methodology

- Manual

## Test environment(s)

- 10.0.100-preview.3.25201.16
@ricardobossan ricardobossan self-assigned this May 9, 2025
@ricardobossan ricardobossan requested a review from a team as a code owner May 9, 2025 21:19
@ricardobossan ricardobossan added the waiting-review This item is waiting on review by one or more members of team label May 9, 2025
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60199%. Comparing base (72ee6eb) to head (d0be84a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13437         +/-   ##
===================================================
+ Coverage   75.43847%   76.60199%   +1.16352%     
===================================================
  Files           3230        3230                 
  Lines         639097      639097                 
  Branches       47289       47289                 
===================================================
+ Hits          482125      489561       +7436     
+ Misses        147952      145968       -1984     
+ Partials        9020        3568       -5452     
Flag Coverage Δ
Debug 76.60199% <ø> (+1.16352%) ⬆️
integration 18.78178% <ø> (?)
production 51.00719% <ø> (+2.59510%) ⬆️
test 97.40411% <ø> (ø)
unit 48.39010% <ø> (-0.02200%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 10, 2025
Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DesignSurfaceExt.csproj has been deleted, dll.ico is no longer used and can be deleted

Copy link
Member

@LeafShi1 LeafShi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small suggestion

@LeafShi1 LeafShi1 requested a review from Tanya-Solyanik May 12, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure waiting-author-feedback The team requires more information from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify DesignSurface and TestConsole into DemoConsole
3 participants