-
Notifications
You must be signed in to change notification settings - Fork 1k
Unify DesignSurface and TestConsole into DemoConsole #13437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify DesignSurface and TestConsole into DemoConsole #13437
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13437 +/- ##
====================================================
- Coverage 76.69388% 51.20921% -25.48467%
====================================================
Files 3255 2063 -1192
Lines 641604 287751 -353853
Branches 47491 42056 -5435
====================================================
- Hits 492071 147355 -344716
+ Misses 145877 137510 -8367
+ Partials 3656 2886 -770
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardobossan DesignSurfaceExt.csproj
has been deleted, dll.ico is no longer used and can be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR unifies the DesignSurface and TestConsole projects into a single DemoConsole project. Key changes include renaming files and updating namespaces to DemoConsole, merging project configuration files and properties into DemoConsole.csproj, and updating the solution file to remove references to the old DesignSurface and DesignSurfaceExt projects.
Reviewed Changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
MainForm.cs | Updated namespace from TestConsole to DemoConsole and added a Timer using alias. |
MainForm.MyUserControl.cs | Updated namespace from TestConsole to DemoConsole. |
MainForm.MyScrollableControl.cs | Updated namespace from TestConsole to DemoConsole. |
GlobalUsings.cs | Revised global using directives, including additions and removals to align with DemoConsole. |
DemoConsole.csproj | Renamed AssemblyName and RootNamespace; merged settings from DesignSurfaceExt and Directory.Build.props into DemoConsole.csproj. |
CustomControls/* | Updated namespaces from TestConsole to DemoConsole. |
Winforms.sln | Removed project references for DesignSurface and DesignSurfaceExt; updated project GUID mappings accordingly. |
Files not reviewed (1)
- src/test/integration/DesignSurface/DemoConsole/MainForm.Designer.cs: Language not supported
Hey @LeafShi1, @ricardobossan what are we doing with this one? It probably would need to be rebased and the requested has not been applied yet (but I only looked so briefly). Do y'all want to keep this? |
d0be84a
to
e89632b
Compare
Tanya's goal was to unify the
Since the first step is already complete, renaming the files and folders is the natural continuation. I've rebased the branch and resolved the merge conflicts. They were straightforward. After the rebase, I tested the I’d recommend moving forward with this PR. @LeafShi1, what do you think? |
It will be fine to keep this. Please resolve the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve the conflict
e89632b
to
e3a74ab
Compare
e3a74ab
to
1b06bef
Compare
Fixes dotnet#13338 - Renamed files in `DesignSurfaceExt` to match the updated class names from PR dotnet#13433 - Moved all code files from `DesignSurfaceExt` into the `DemoConsole` project directory - Integrated all relevant configuration from `DesignSurfaceExt.csproj` into `DemoConsole.csproj` - Deleted `DesignSurfaceExt.csproj` - Merged the contents of `Directory.Build.props` into `DemoConsole.csproj` to consolidate all settings in one place - Removed the now redundant `Directory.Build.props` file - Relocated the `DemoConsole` folder up one level to align with other integration test projects - Deleted the now empty `DesignSurfaceExt` folder - None - Minimal - Manual - 10.0.100-preview.3.25201.16
1b06bef
to
5dc54c8
Compare
Fixes #13388
Proposed changes
DesignSurfaceExt
to match the updated class names from PR Unify namespaces and class names under DemoConsole #13433DesignSurfaceExt
into theDemoConsole
project directoryDesignSurfaceExt.csproj
intoDemoConsole.csproj
DesignSurfaceExt.csproj
Directory.Build.props
intoDemoConsole.csproj
to consolidate all settings in one placeDirectory.Build.props
fileDemoConsole
folder up one level to align with other integration test projectsDesignSurfaceExt
folderCustomer Impact
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow