-
Notifications
You must be signed in to change notification settings - Fork 1k
Unify DesignSurface and TestConsole into DemoConsole #13437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unify DesignSurface and TestConsole into DemoConsole #13437
Conversation
Fixes dotnet#13338 ## Proposed changes - Renamed files in `DesignSurfaceExt` to match the updated class names from PR dotnet#13433 - Moved all code files from `DesignSurfaceExt` into the `DemoConsole` project directory - Integrated all relevant configuration from `DesignSurfaceExt.csproj` into `DemoConsole.csproj` - Deleted `DesignSurfaceExt.csproj` - Merged the contents of `Directory.Build.props` into `DemoConsole.csproj` to consolidate all settings in one place - Removed the now redundant `Directory.Build.props` file - Relocated the `DemoConsole` folder up one level to align with other integration test projects - Deleted the now empty `DesignSurfaceExt` folder ## Customer Impact - None ## Risk - Minimal ## Test methodology - Manual ## Test environment(s) - 10.0.100-preview.3.25201.16
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13437 +/- ##
===================================================
+ Coverage 75.43847% 76.60199% +1.16352%
===================================================
Files 3230 3230
Lines 639097 639097
Branches 47289 47289
===================================================
+ Hits 482125 489561 +7436
+ Misses 147952 145968 -1984
+ Partials 9020 3568 -5452
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DesignSurfaceExt.csproj
has been deleted, dll.ico is no longer used and can be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small suggestion
Fixes #13388
Proposed changes
DesignSurfaceExt
to match the updated class names from PR Unify namespaces and class names under DemoConsole #13433DesignSurfaceExt
into theDemoConsole
project directoryDesignSurfaceExt.csproj
intoDemoConsole.csproj
DesignSurfaceExt.csproj
Directory.Build.props
intoDemoConsole.csproj
to consolidate all settings in one placeDirectory.Build.props
fileDemoConsole
folder up one level to align with other integration test projectsDesignSurfaceExt
folderCustomer Impact
Risk
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow