-
Notifications
You must be signed in to change notification settings - Fork 1k
Add code coverage for RadioButtonRenderer #13447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add code coverage for RadioButtonRenderer #13447
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13447 +/- ##
====================================================
+ Coverage 62.21083% 97.40182% +35.19099%
====================================================
Files 3213 1176 -2037
Lines 638302 352709 -285593
Branches 47201 5360 -41841
====================================================
- Hits 397093 343545 -53548
+ Misses 234153 8407 -225746
+ Partials 7056 757 -6299
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds unit tests for the RadioButtonRenderer to improve code coverage for both public and internal methods and properties.
- Introduces multiple test cases for rendering behaviors, state conversion, and background drawing.
- Adds tests that validate behavior changes based on whether visual styles are enabled.
Comments suppressed due to low confidence (1)
src/test/unit/System.Windows.Forms/System/Windows/Forms/RadioButtonRendererTests.cs:1
- The removal of '#nullable disable' suggests the file is now intended to support nullable reference types. Ensure that the rest of the file adheres to the project's nullability guidelines.
-#nullable disable
src/test/unit/System.Windows.Forms/System/Windows/Forms/RadioButtonRendererTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a small comment, all LGTM!
src/test/unit/System.Windows.Forms/System/Windows/Forms/RadioButtonRendererTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related #13442
Proposed changes
Add unit test file: RadioButtonRendererTests.cs for public/Internal methods & properties of the RadioButtonRenderer.cs
Microsoft Reviewers: Open in CodeFlow