Refactor icon initialization and make use of CreateIconResourceDirectory() for improved accuracy #13448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJm00n
force-pushed
the
icon
branch
4 times, most recently
from
30a218b to
e930ec2
Compare
DJm00n
changed the title
…ory() for improved efficiency - Refactored Icon.Initialize() method, replacing manual icon selection logic with LookupIconIdFromDirectoryEx() for better accuracy. - Introduced CreateIconResourceDirectory(), simplifying RT_GROUP_ICON data creation from ICO file data. - Removed redundant s_bitDepth field, relying on direct calculations when needed. - Eliminated unnecessary width/height calculations, replacing them with direct system metric retrieval. - Optimized memory handling, avoiding unnecessary spans and copies while ensuring correct alignment. - Functionality remains unchanged, but initialization is now more efficient and maintainable - Three test cases where changed due to LookupIconIdFromDirectoryEx() icon selection logic (used in Windows)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13448 +/- ##
====================================================
+ Coverage 62.21083% 97.40438% +35.19355%
====================================================
Files 3213 1176 -2037
Lines 638302 352555 -285747
Branches 47201 5355 -41846
====================================================
- Hits 397093 343404 -53689
+ Misses 234153 8398 -225755
+ Partials 7056 753 -6303
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer Impact
Regression?
Microsoft Reviewers: Open in CodeFlow