Add code coverage for CheckBox #13455
Open
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13455 +/- ##
====================================================
+ Coverage 62.21083% 76.60706% +14.39623%
====================================================
Files 3213 3230 +17
Lines 638302 639133 +831
Branches 47201 47291 +90
====================================================
+ Hits 397093 489621 +92528
+ Misses 234153 145937 -88216
+ Partials 7056 3575 -3481
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Zheng-Li01
added
the
waiting-review
Epica3055
reviewed
May 14, 2025
src/test/unit/System.Windows.Forms/System/Windows/Forms/CheckBoxTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/CheckBoxTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/CheckBoxTests.cs
Outdated
Show resolved
Hide resolved
Open
48 tasks
There was a problem hiding this comment.
Pull Request Overview
Adds unit tests for internal CheckBox methods to improve code coverage, focusing on preferred size calculations under different styles and minimum height enforcement.
- Introduces a parameterized Theory covering various
AppearanceandFlatStylecombinations inGetPreferredSizeCore. - Adds a Fact to ensure a minimum height is enforced by
GetPreferredSizeCore.
src/test/unit/System.Windows.Forms/System/Windows/Forms/CheckBoxTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/CheckBoxTests.cs
Show resolved
Hide resolved
ricardobossan
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13442
Proposed changes
Add unit test file: CheckBoxTests.cs for Internal methods of the CheckBox.cs
Microsoft Reviewers: Open in CodeFlow