Skip to content

DarkMode (e) fix TabControl issues #13466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented May 16, 2025

Fixes #11953.

Microsoft Reviewers: Open in CodeFlow

KlausLoeffelmann and others added 26 commits May 16, 2025 14:57
...proof, that the existing Unit Tests are doing a fantastic job!
@github-actions github-actions bot added the area-DarkMode Issues relating to Dark Mode feature label May 16, 2025
@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label May 16, 2025
@KlausLoeffelmann KlausLoeffelmann force-pushed the DarkMode_e_FixTabControlIssues branch from c121454 to 79d2b5d Compare May 17, 2025 00:39
Copy link

codecov bot commented May 17, 2025

Codecov Report

Attention: Patch coverage is 13.22870% with 1161 lines in your changes missing coverage. Please review.

Project coverage is 76.50826%. Comparing base (c78c1e9) to head (79d2b5d).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13466         +/-   ##
===================================================
- Coverage   76.60074%   76.50826%   -0.09248%     
===================================================
  Files           3230        3239          +9     
  Lines         639097      640276       +1179     
  Branches       47289       47409        +120     
===================================================
+ Hits          489553      489864        +311     
- Misses        145962      146838        +876     
+ Partials        3582        3574          -8     
Flag Coverage Δ
Debug 76.50826% <13.22870%> (-0.09248%) ⬇️
integration 18.81369% <5.82960%> (+0.03296%) ⬆️
production 50.90349% <13.22870%> (-0.10091%) ⬇️
test 97.40411% <ø> (ø)
unit 48.20989% <13.07922%> (-0.20499%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KlausLoeffelmann KlausLoeffelmann marked this pull request as ready for review May 17, 2025 04:04
@KlausLoeffelmann KlausLoeffelmann requested a review from a team as a code owner May 17, 2025 04:04
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DarkMode Issues relating to Dark Mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark Mode] TabControl is not in dark mode after enabled SystemColorMode.Dark
2 participants