DarkMode (c) Fix TitleBar issues #13468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13468 +/- ##
===================================================
- Coverage 76.60074% 76.47531% -0.12544%
===================================================
Files 3230 3239 +9
Lines 639097 640238 +1141
Branches 47289 47403 +114
===================================================
+ Hits 489553 489624 +71
- Misses 145962 147041 +1079
+ Partials 3582 3573 -9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
[main] Source code updates from dotnet/dotnet
[main] Source code updates from dotnet/dotnet
Chromium based apps don't support file drop without using IDataObjectAsyncCapability. This includes the new Outlook. To support this we'll look for this interface in our current code paths and utilize it. This makes the async operation sync, which works, but isn't ideal. Chromium will pop a dialog that will leave WinForms modal as well until it is responded to. If this behavior creates an issue it can be disabled with the appcontext switch: "Windows.DragDrop.DisableSyncOverAsync" In order to truly support async we're also introducing a new interface to allow calling back off of the UI thread. This will be shipped as experimental for .NET 10 as there is a small risk we'll want to change the API based on real-world feedback. See dotnet#13422.
###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/winforms/pull/13479)
* Initial plan for issue * Fix thread safety in Application.ThreadContext.FromId Co-authored-by: JeremyKuhne <[email protected]> * Optimize lock usage in Application.ThreadContext.FromId Co-authored-by: JeremyKuhne <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JeremyKuhne <[email protected]>
[main] Source code updates from dotnet/dotnet
…background painting.
...proof, that the existing Unit Tests are doing a fantastic job!
Co-authored-by: KlausLoeffelmann <[email protected]>
Co-authored-by: KlausLoeffelmann <[email protected]>
Co-authored-by: KlausLoeffelmann <[email protected]>
…ession-bodied form Co-authored-by: KlausLoeffelmann <[email protected]>
Co-authored-by: KlausLoeffelmann <[email protected]>
KlausLoeffelmann
force-pushed
the
DarkMode_c_FixTitleBars2
branch
from
c68dc30 to
e0697dc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12992.
Microsoft Reviewers: Open in CodeFlow