Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 22, 2025

Backport of #13983 to release/10.0

/cc @JeremyKuhne

Customer Impact

Users setting a Form Icon that matches the current screen small icon size will have their Icon disposed, causing an ObjectDisposedException when using the original Icon. There is no easy workaround.

Testing

Manual testing with user scenario. Regression test.

Risk

Low, now always creating a new Icon instance.

If the user provided icon matched the size of the small icon we would delete it. Add a regression test.
@github-actions github-actions bot requested a review from a team as a code owner October 22, 2025 22:47
@JeremyKuhne JeremyKuhne added the servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria label Oct 22, 2025
@JeremyKuhne JeremyKuhne added this to the .NET 10.0 milestone Oct 22, 2025
@JeremyKuhne JeremyKuhne added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.10578%. Comparing base (d5eebf7) to head (ac2f620).
⚠️ Report is 2 commits behind head on release/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/10.0      #13984         +/-   ##
======================================================
+ Coverage      77.09712%   77.10578%   +0.00865%     
======================================================
  Files              3273        3273                 
  Lines            644932      644940          +8     
  Branches          47692       47692                 
======================================================
+ Hits             497224      497286         +62     
+ Misses           144031      143986         -45     
+ Partials           3677        3668          -9     
Flag Coverage Δ
Debug 77.10578% <100.00000%> (+0.00865%) ⬆️
integration 18.99113% <75.00000%> (+0.01064%) ⬆️
production 51.92353% <100.00000%> (+0.01825%) ⬆️
test 97.41256% <100.00000%> (+0.00007%) ⬆️
unit 49.33590% <100.00000%> (+0.00919%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JeremyKuhne JeremyKuhne added servicing-approved .NET Shiproom approved the PR for merge and removed servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels Oct 23, 2025
@JeremyKuhne JeremyKuhne merged commit 93e65c0 into release/10.0 Oct 23, 2025
8 checks passed
@JeremyKuhne JeremyKuhne deleted the backport/pr-13983-to-release/10.0 branch October 23, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

servicing-approved .NET Shiproom approved the PR for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants