Disable parallel mode for test collections and reenable flaky tests. #8772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreddy-work
added
the
🚫 * NO-MERGE *
This was referenced Mar 9, 2023
Remove explicit collection definition that doe snothingbut disable parallelization
RussKie
reviewed
Mar 11, 2023
src/Microsoft.VisualBasic.Forms/tests/UnitTests/xunit.runner.json
Outdated
Show resolved
Hide resolved
|
vsplit.cur and hsplit.cur are consistent in resulting disposed handle ( or handle may never be created). |
…ispose cateorize them as `owned` while disposing.
This was referenced Mar 12, 2023
This was referenced Mar 13, 2023
Flaky test: dragenter_set_dropimagetype_message_messagereplacementtoken_returnsexptected_async
#8746
Open
dreddy-work
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
RussKie
reviewed
Mar 14, 2023
RussKie
reviewed
Mar 14, 2023
...System.Windows.Forms.Primitives/tests/UnitTests/System.Windows.Forms.Primitives.Tests.csproj
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
JeremyKuhne
requested changes
Mar 15, 2023
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "maxParallelThreads": 1, | |||
There was a problem hiding this comment.
Making everything serial should have a follow up issue for tracking if it doesn't already. It is unfortunate that we can't add comments in json. Doing this will facilitate adding poorly written tests making it harder and harder to go back to parallel testing.
| @@ -28,6 +28,10 @@ | |||
| <EnableTrimAnalyzer Condition="$(IsTestProject) or $(IsAnalyzerProject) or $(MSBuildProjectDirectory.Contains('\tests\'))">false</EnableTrimAnalyzer> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(IsTestProject)' == 'true'"> | |||
There was a problem hiding this comment.
This would be a good place to have a comment for our re-parallelization tracking issue.
ghost
added
the
waiting-author-feedback
|
Closing as we are trying to remove all delays and a part of these changes are taken separately. |
ghost
removed
the
waiting-author-feedback
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing theory of "disabling test collection parallelism may be fixing flaky tests".
changes:
hsplit.curandvsplit.cur. They need special attention. Possibly a bug that has been there since Framework.InputSimulatorfor a more permeant and reliable solution.Related tests re-enabled:
fixes #8750 fixes #8748 fixes #8747 fixes #8746 fixes #8740 fixes #8734 fixes #8726 fixes #8723 fixes #8709 fixes #8682 fixes #8635 fixes #8634 fixes #8632 fixes #8619 fixes #8612 fixes #8611 fixes #8609 fixes #8604 fixes #8602 fixes #8601 fixes #8520 fixes #8521 fixes #8373 fixes #8223 fixes #7428 fixes #7407 fixes #7297 fixes #6610 fixes #6654 fixes #6714 fixes #6729 fixes #4212 fixes #3918 fixes #3647 fixes #3456 fixes #2856
Microsoft Reviewers: Open in CodeFlow