-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add XamlObjectCreationFactory to improve the performance of XAML creation of objects #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lindexi
wants to merge
7
commits into
dotnet:main
Choose a base branch
from
dotnet-campus:t/lindexi/XamlObjectCreationFactory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add XamlObjectCreationFactory to improve the performance of XAML creation of objects #4026
lindexi
wants to merge
7
commits into
dotnet:main
from
dotnet-campus:t/lindexi/XamlObjectCreationFactory
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindexi
added a commit
to lindexi/lindexi_gd
that referenced
this pull request
Jan 20, 2021
lindexi
added a commit
to lindexi/lindexi_gd
that referenced
this pull request
Jan 20, 2021
lindexi
added a commit
to lindexi/lindexi_gd
that referenced
this pull request
Jan 20, 2021
lindexi
added a commit
to lindexi/lindexi_gd
that referenced
this pull request
Jan 20, 2021
lindexi
added a commit
to lindexi/lindexi_gd
that referenced
this pull request
Jan 20, 2021
…amlObjectCreationFactory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API Review Requested
Community Contribution
A label for all community Contributions
Performance
Performance related issue
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #4022
This feature can improve the performance of XAML object creation by three times
Benchmark:
BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19041.746 (2004/?/20H1)
Intel Core i7-6700 CPU 3.40GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.101
[Host] : .NET Core 5.0.1 (CoreCLR 5.0.120.57516, CoreFX 5.0.120.57516), X64 RyuJIT
DefaultJob : .NET Core 5.0.1 (CoreCLR 5.0.120.57516, CoreFX 5.0.120.57516), X64 RyuJIT
Benchmark code: https://github.com/lindexi/lindexi_gd/blob/8f95aafa/System.Xaml/System.Xaml.Demo/Program.cs
This will hardly make the original performance worse, if we do not use this feature. Benchmark code: https://github.com/lindexi/lindexi_gd/blob/58bbf616/System.Xaml/System.Xaml.Demo/Program.cs
BenchmarkDotNet=v0.12.1, OS=Windows 10.0.19041.746 (2004/?/20H1)
Intel Core i7-6700 CPU 3.40GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.101
[Host] : .NET Core 5.0.1 (CoreCLR 5.0.120.57516, CoreFX 5.0.120.57516), X64 RyuJIT
DefaultJob : .NET Core 5.0.1 (CoreCLR 5.0.120.57516, CoreFX 5.0.120.57516), X64 RyuJIT
About Ioc
Register by IServiceCollection :
See #499