Skip to content

[release/6.0-preview6] Update dependencies from dotnet/winforms - #4686

Merged
mmitche merged 2 commits into
release/6.0-preview6from
darc-release/6.0-preview6-cc890565-a8e1-43aa-ab4c-8990f5f1c978
Jun 17, 2021
Merged

[release/6.0-preview6] Update dependencies from dotnet/winforms#4686
mmitche merged 2 commits into
release/6.0-preview6from
darc-release/6.0-preview6-cc890565-a8e1-43aa-ab4c-8990f5f1c978

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • System.CodeDom: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Configuration.ConfigurationManager: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Diagnostics.EventLog: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.DirectoryServices: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Drawing.Common: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Reflection.MetadataLoadContext: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Security.Cryptography.Xml: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Security.Permissions: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Windows.Extensions: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • Microsoft.NETCore.Platforms: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.IO.Packaging: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • Microsoft.NETCore.ILDAsm: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • Microsoft.NETCore.ILAsm: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • System.Resources.Extensions: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • Microsoft.NETCore.App.Ref: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)
    • VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.6.21314.2 to 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms)

From https://github.com/dotnet/winforms

  • Subscription: db6d92b8-09e6-41b3-2268-08d9301a7045
  • Build: 20210616.3
  • Date Produced: 6/16/2021 4:17 PM
  • Commit: 6a9d2f53a45bb9df68c8ac0d5aa6d7fdf49ae84f
  • Branch: refs/heads/release/6.0-preview6

@dotnet-maestro
Update dependencies from https://github.com/dotnet/winforms build 202…
b156453 
…10616.3

Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms
 From Version 6.0.0-preview.6.21315.7 -> To Version 6.0.0-preview.6.21316.3

Dependency coherency updates

System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0
 From Version 6.0.0-preview.6.21314.2 -> To Version 6.0.0-preview.6.21315.7 (parent: Microsoft.Private.Winforms
@dotnet-maestro
dotnet-maestro Bot requested a review from a team as a code owner June 16, 2021 16:46
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 16, 2021
@ghost
ghost requested review from SamBent, fabiant3 and ryalanms June 16, 2021 16:46
@mmitche

mmitche commented Jun 16, 2021

Copy link
Copy Markdown
Member

https://dev.azure.com/dnceng/public/_build/results?buildId=1190324&view=results

@mmitche

mmitche commented Jun 16, 2021

Copy link
Copy Markdown
Member

@ryalanms

##[error]src\Microsoft.DotNet.Wpf\src\PresentationUI\MS\Internal\Documents\Application\DocumentStream.cs(549,9): error CS1069: (NETCORE_ENGINEERING_TELEMETRY=Build) The type name 'FileSecurity' could not be found in the namespace 'System.Security.AccessControl'. This type has been forwarded to assembly 'System.IO.FileSystem.AccessControl, Version=0.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' Consider adding a reference to that assembly.
D:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\PresentationUI\MS\Internal\Documents\Application\DocumentStream.cs(549,54): error CS1061: 'FileInfo' does not contain a definition for 'GetAccessControl' and no accessible extension method 'GetAccessControl' accepting a first argument of type 'FileInfo' could be found (are you missing a using directive or an assembly reference?) [D:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\PresentationUI\PresentationUI_1bcpr5z3_wpftmp.csproj]
##[error]src\Microsoft.DotNet.Wpf\src\PresentationUI\MS\Internal\Documents\Application\DocumentStream.cs(549,54): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'FileInfo' does not contain a definition for 'GetAccessControl' and no accessible extension method 'GetAccessControl' accepting a first argument of type 'FileInfo' could be found (are you missing a using directive or an assembly reference?)
D:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\PresentationUI\MS\Internal\Documents\Application\DocumentStream.cs(586,30): error CS1061: 'FileInfo' does not contain a definition for 'SetAccessControl' and no accessible extension method 'SetAccessControl' accepting a first argument of type 'FileInfo' could be found (are you missing a using directive or an assembly reference?) [D:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\PresentationUI\PresentationUI_1bcpr5z3_wpftmp.csproj]
##[error]src\Microsoft.DotNet.Wpf\src\PresentationUI\MS\Internal\Documents\Application\DocumentStream.cs(586,30): error CS1061: (NETCORE_ENGINEERING_TELEMETRY=Build) 'FileInfo' does not contain a definition for 'SetAccessControl' and no accessible extension method 'SetAccessControl' accepting a first argument of type 'FileInfo' could be found (are you missing a using directive or an assembly reference?)

@ryalanms

ryalanms commented Jun 16, 2021

Copy link
Copy Markdown
Member

@mmitche: I'm looking now. Did the runtime update change public API surface?

/cc @dotnet/wpf-developers

@mmitche

mmitche commented Jun 16, 2021

Copy link
Copy Markdown
Member

@mmitche: I'm looking now. Did the runtime update change public API surface?

/cc @dotnet/wpf-developers

I am not sure. @dotnet/dnr-codeflow?

@ryalanms

ryalanms commented Jun 17, 2021

Copy link
Copy Markdown
Member

@mmitche: This should be resolved.

@ryalanms

ryalanms commented Jun 17, 2021

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

azure-pipelines Bot commented Jun 17, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mmitche

mmitche commented Jun 17, 2021

Copy link
Copy Markdown
Member

Green here: https://dev.azure.com/dnceng/public/_build/results?buildId=1191320&view=results

@mmitche
mmitche merged commit 56bf228 into release/6.0-preview6 Jun 17, 2021
@dotnet-maestro
dotnet-maestro Bot deleted the darc-release/6.0-preview6-cc890565-a8e1-43aa-ab4c-8990f5f1c978 branch June 17, 2021 01:36
@danmoseley

danmoseley commented Jun 17, 2021

Copy link
Copy Markdown

This is likely a consequence of dotnet/runtime#54147. @ViktorHofer is it expected that @ryalanms had to add the direct reference to fix a build break? Will customers hit this?

@ViktorHofer

ViktorHofer commented Jun 17, 2021

Copy link
Copy Markdown
Member

@mmitche: I'm looking now. Did the runtime update change public API surface?

Yes and if you are part of the wpf-developers alias, you should have gotten a mail about this. We also need to remove the references from the windowsdesktop targeting pack as a follow-up.

This is likely a consequence of dotnet/runtime#54147. @ViktorHofer is it expected that @ryalanms had to add the direct reference to fix a build break? Will customers hit this?

No customers won't hit this as this is a very custom infrastructure. Wpf defines granular NetCoreApp references instead of just referencing all which is the default behavior.

@danmoseley

danmoseley commented Jun 17, 2021

Copy link
Copy Markdown

Thanks for clarification @ViktorHofer - sounds good

@ViktorHofer ViktorHofer mentioned this pull request Jun 17, 2021
Merged
@ViktorHofer

ViktorHofer commented Jun 17, 2021

Copy link
Copy Markdown
Member

Do we need to port this into main manually or is there a bot for that?

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3
@ryalanms ryalanms Awaiting requested review from ryalanms
@SamBent SamBent Awaiting requested review from SamBent

Assignees

No one assigned

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmitche @ryalanms @danmoseley @ViktorHofer