Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real task status #176

Merged
merged 4 commits into from
Apr 3, 2025
Merged

Conversation

dispensable
Copy link
Contributor

  • show task running/no_status(-) etc status in task table

user often feels confused with the default task failed status (even when task is not scheduled to run)

@dispensable dispensable requested a review from Copilot April 3, 2025 09:06
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the task status display logic to show the real task status in the task table, addressing user confusion with the default failed status.

  • Updates backend logic to compute and filter task statuses using a new task_status variable.
  • Improves frontend display by using specific color-coded tags for success, failed, and other statuses.
  • Upgrades node_modules caching in CI workflows to actions/cache v3.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
helpdesk/models/provider/airflow.py Adjusts task status reporting and filtering to use a new status value
frontend/components/ResultHostTable.vue Updates status tag rendering and logic to handle additional statuses
.github/workflows/test.yml Updates caching version to actions/cache v3
.github/workflows/release.yml Updates caching version to actions/cache v3
Comments suppressed due to low confidence (1)

helpdesk/models/provider/airflow.py:307

  • The updated key format for tasks_result has changed from using a '->' separator to a space. Please verify that downstream code consuming these keys is updated accordingly to prevent potential issues.
tasks_result[f'{task_id} [{tries_time+1}/{task_tried_times}]'] = {

@dispensable dispensable merged commit debb6a1 into douban:master Apr 3, 2025
2 checks passed
@dispensable dispensable deleted the show_real_task_status branch April 3, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant