Skip to content

chore: Turn URL comments into properties #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

sschuberth
Copy link
Contributor

@sschuberth sschuberth commented Dec 15, 2023

This is just an idea that I only implemented at a single example to clarify: How does the @doubleopen-project/team think about turning URL comments into properties, so they become machine readable / actionable in rules?

Signed-off-by: Sebastian Schuberth <[email protected]>
@mmurto
Copy link
Member

mmurto commented Dec 17, 2023

Excellent idea IMO! Does ORT give errors for license classifications that are used but not defined?

@Etsija
Copy link
Member

Etsija commented Dec 18, 2023

I also think this is an excellent idea.

@sschuberth
Copy link
Contributor Author

Does ORT give errors for license classifications that are used but not defined?

Yes, that's why currently the CI check fails. But this actually is a blocker here: We'd not want to define a category for each different URL... not sure how to solve that yet.

@mmurto
Copy link
Member

mmurto commented Dec 18, 2023

If the check for unknown categories was "relegated" to Evaluator rules from ORT's license classification parsing logic, that would allow only checking for categories that aren't prefixed by url, for example. If possible, a low-friction way could be that the evaluator rules had a default logic that checks for unknown categories as it is know, but it could be overriden in evaluator.rules.kts. Do you think it would be possible?

@sschuberth
Copy link
Contributor Author

Do you think it would be possible?

It's surely technically possible, but I believe there would be push-back from members of the ORT community for such a breaking change. I'll clarify on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants