Skip to content

filtering out the staff details to non-staff roles hence fixing insec… #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atharv2-git wants to merge 1 commit into from
Closed

filtering out the staff details to non-staff roles hence fixing insec… #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/api/entities/unit_entity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def can_read_unit_config?(my_role)
expose :tutorial_streams, using: TutorialStreamEntity, unless: :summary_only

# Expose staff before tutorials, so that their details are available
expose :staff, using: UnitRoleEntity, unless: :summary_only
expose :staff, using: UnitRoleEntity, unless: :summary_only, if: lambda { |unit, options| is_staff?(options[:my_role]) } # filtering out the staff_data object for non_staff_roles
expose :tutorials, using: TutorialEntity, unless: :summary_only
# expose :tutorial_enrolments, using: TutorialEnrolmentEntity, unless: :summary_only, if: lambda { |unit, options| is_staff?(options[:my_role]) }

Expand Down